awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4314 from Infisical/fix/editButNotReadValuesFixForCommitRows

Browse Source 
Fix edge case where users with edit but not read permission on new commit row logic
This commit is contained in:
carlosmonastyrski
2025-08-05 15:32:59 -03:00
committed by GitHub
parent 6be65f7a56 08f7e530b0
commit 4e3613ac6e
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretItem.tsx
View File

@@ -142,7 +142,7 @@ export const SecretItem = memo(
); );
const getDefaultValue = () => { const getDefaultValue = () => {
if (secret.secretValueHidden) { if (secret.secretValueHidden && !isPending) {
return canEditSecretValue ? HIDDEN_SECRET_VALUE : ""; return canEditSecretValue ? HIDDEN_SECRET_VALUE : "";
} }
return secret.valueOverride || secret.value || ""; return secret.valueOverride || secret.value || "";
@@ -413,7 +413,7 @@ export const SecretItem = memo(
tabIndex={0} tabIndex={0}
role="button" role="button"
> >
{secretValueHidden && !isOverriden && ( {secretValueHidden && !isOverriden && !isPending && (
<Tooltip <Tooltip
content={`You do not have access to view the current value${canEditSecretValue && !isRotatedSecret ? ", but you can set a new one" : "."}`} content={`You do not have access to view the current value${canEditSecretValue && !isRotatedSecret ? ", but you can set a new one" : "."}`}
> >
@@ -444,12 +444,14 @@ export const SecretItem = memo(
<InfisicalSecretInput <InfisicalSecretInput
isReadOnly={isReadOnlySecret} isReadOnly={isReadOnlySecret}
key="secret-value" key="secret-value"
isVisible={isVisible && !secretValueHidden} isVisible={isVisible && (!secretValueHidden || isPending)}
canEditButNotView={secretValueHidden && !isOverriden} canEditButNotView={secretValueHidden && !isOverriden && !isPending}
environment={environment} environment={environment}
secretPath={secretPath} secretPath={secretPath}
{...field} {...field}
defaultValue={secretValueHidden ? HIDDEN_SECRET_VALUE : undefined} defaultValue={
secretValueHidden && !isPending ? HIDDEN_SECRET_VALUE : undefined
}
containerClassName="py-1.5 rounded-md transition-all" containerClassName="py-1.5 rounded-md transition-all"
/> />
)} )}