From 50d0035d7b593e752312c3352e0e55a9814c00fb Mon Sep 17 00:00:00 2001
From: Scott Wilson <scottraywilson@gmail.com>
Date: Mon, 12 May 2025 14:56:13 -0700
Subject: [PATCH] fix: correct remove oci secret if secret value is empty logic

---
 .../services/secret-sync/oci-vault/oci-vault-sync-fns.ts    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/backend/src/services/secret-sync/oci-vault/oci-vault-sync-fns.ts b/backend/src/services/secret-sync/oci-vault/oci-vault-sync-fns.ts
index 14cb8a60e..95045e1e9 100644
--- a/backend/src/services/secret-sync/oci-vault/oci-vault-sync-fns.ts
+++ b/backend/src/services/secret-sync/oci-vault/oci-vault-sync-fns.ts
@@ -213,8 +213,8 @@ export const OCIVaultSyncFns = {
     for await (const [key, variable] of Object.entries(variables)) {
       // Only update / delete active secrets
       if (variable.lifecycleState === vault.models.SecretSummary.LifecycleState.Active) {
-        if (key in secretMap) {
-          if (variable.value !== secretMap[key].value && secretMap[key].value.length > 0) {
+        if (key in secretMap && secretMap[key].value.length > 0) {
+          if (variable.value !== secretMap[key].value) {
             try {
               await updateOCIVaultVariable({
                 compartmentId: compartmentOcid,
@@ -230,7 +230,7 @@ export const OCIVaultSyncFns = {
               });
             }
           }
-        } else if (!secretSync.syncOptions.disableSecretDeletion || !secretMap[key].value) {
+        } else if (!secretSync.syncOptions.disableSecretDeletion) {
           try {
             await deleteOCIVaultVariable({
               compartmentId: compartmentOcid,