Revise pr based on greptile review

backend/src/ee/services/ssh-host/ssh-host-schema.ts

@@ -14,7 +14,7 @@ export const sanitizedSshHost = SshHostsSchema.pick({
 });
 
 export const loginMappingSchema = z.object({
-  loginUser: z.string().trim(),
+  loginUser: z.string().trim().min(1).max(32),
   allowedPrincipals: z.object({
     usernames: z
       .array(z.string().trim())

backend/src/lib/api-docs/constants.ts

@@ -1735,6 +1735,15 @@ export const PKI_SUBSCRIBERS = {
     privateKey: "The private key of the issued certificate.",
     serialNumber: "The serial number of the issued certificate."
   },
+  SIGN_CERT: {
+    subscriberName: "The name of the PKI subscriber to sign the certificate for.",
+    projectId: "The ID of the project of the PKI subscriber to sign the certificate for.",
+    csr: "The CSR to be used to sign the certificate.",
+    certificate: "The signed certificate.",
+    issuingCaCertificate: "The certificate of the issuing CA.",
+    certificateChain: "The certificate chain of the signed certificate.",
+    serialNumber: "The serial number of the signed certificate."
+  },
   LIST_CERTS: {
     subscriberName: "The name of the PKI subscriber to list the certificates for.",
     projectId: "The ID of the project of the PKI subscriber to list the certificates for.",

backend/src/server/routes/v1/pki-subscriber-router.ts

@@ -361,17 +361,17 @@ export const registerPkiSubscriberRouter = async (server: FastifyZodProvider) =>
       tags: [ApiDocsTags.PkiSubscribers],
       description: "Sign certificate",
       params: z.object({
-        subscriberName: z.string().describe(PKI_SUBSCRIBERS.ISSUE_CERT.subscriberName)
+        subscriberName: z.string().describe(PKI_SUBSCRIBERS.SIGN_CERT.subscriberName)
       }),
       body: z.object({
-        projectId: z.string().trim().describe(PKI_SUBSCRIBERS.ISSUE_CERT.projectId),
-        csr: z.string().trim().min(1)
+        projectId: z.string().trim().describe(PKI_SUBSCRIBERS.SIGN_CERT.projectId),
+        csr: z.string().trim().min(1).max(3000).describe(PKI_SUBSCRIBERS.SIGN_CERT.csr)
       }),
       response: {
         200: z.object({
-          certificate: z.string().trim().describe(PKI_SUBSCRIBERS.ISSUE_CERT.certificate),
-          issuingCaCertificate: z.string().trim().describe(PKI_SUBSCRIBERS.ISSUE_CERT.issuingCaCertificate),
-          certificateChain: z.string().trim().describe(PKI_SUBSCRIBERS.ISSUE_CERT.certificateChain),
+          certificate: z.string().trim().describe(PKI_SUBSCRIBERS.SIGN_CERT.certificate),
+          issuingCaCertificate: z.string().trim().describe(PKI_SUBSCRIBERS.SIGN_CERT.issuingCaCertificate),
+          certificateChain: z.string().trim().describe(PKI_SUBSCRIBERS.SIGN_CERT.certificateChain),
           serialNumber: z.string().trim().describe(PKI_SUBSCRIBERS.ISSUE_CERT.serialNumber)
         })
       }
@@ -412,7 +412,7 @@ export const registerPkiSubscriberRouter = async (server: FastifyZodProvider) =>
       });
 
       return {
-        certificate: certificate.toString("pem"),
+        certificate,
         certificateChain,
         issuingCaCertificate,
         serialNumber

backend/src/server/routes/v2/project-router.ts

@@ -498,6 +498,8 @@ export const registerProjectRouter = async (server: FastifyZodProvider) => {
       rateLimit: readLimit
     },
     schema: {
+      hide: false,
+      tags: [ApiDocsTags.PkiSubscribers],
       params: z.object({
         projectId: z.string().trim().describe(PROJECTS.LIST_PKI_SUBSCRIBERS.projectId)
       }),

backend/src/services/pki-subscriber/pki-subscriber-service.ts

@@ -706,7 +706,7 @@ export const pkiSubscriberServiceFactory = ({
     });
 
     return {
-      certificate: leafCert,
+      certificate: leafCert.toString("pem"),
       certificateChain: `${issuingCaCertificate}\n${caCertChain}`.trim(),
       issuingCaCertificate,
       serialNumber,