misc: address comments

This commit is contained in:
Sheen Capadngan
2025-04-11 21:47:30 +08:00
parent 06715b1b58
commit 53ca8d7161
2 changed files with 19 additions and 7 deletions
@@ -84,6 +84,11 @@ export const camundaSyncFactory = ({ kmsService, appConnectionDAL }: TCamundaSec
for await (const entry of Object.entries(secretMap)) { for await (const entry of Object.entries(secretMap)) {
const [key, { value }] = entry; const [key, { value }] = entry;
if (!value) {
// eslint-disable-next-line no-continue
continue;
}
try { try {
if (camundaSecrets[key] === undefined) { if (camundaSecrets[key] === undefined) {
await createCamundaSecret({ await createCamundaSecret({
@@ -111,12 +116,19 @@ export const camundaSyncFactory = ({ kmsService, appConnectionDAL }: TCamundaSec
if (secretSync.syncOptions.disableSecretDeletion) return; if (secretSync.syncOptions.disableSecretDeletion) return;
for await (const secret of Object.keys(camundaSecrets)) { for await (const secret of Object.keys(camundaSecrets)) {
if (!(secret in secretMap)) { if (!(secret in secretMap) || !secretMap[secret].value) {
await deleteCamundaSecret({ try {
key: secret, await deleteCamundaSecret({
clusterUUID, key: secret,
accessToken clusterUUID,
}); accessToken
});
} catch (error) {
throw new SecretSyncError({
error,
secretKey: secret
});
}
} }
} }
}; };
@@ -103,7 +103,7 @@ export const CamundaConnectionForm = ({ appConnection, onSubmit }: Props) => {
isError={Boolean(error?.message)} isError={Boolean(error?.message)}
label="Client ID" label="Client ID"
> >
<Input {...field} placeholder="05810c8f-c44d-4bd0-a327-aab6dd77719b" /> <Input {...field} placeholder="YrBDnQYLevSe40PJ" />
</FormControl> </FormControl>
)} )}
/> />