diff --git a/frontend/src/components/dashboard/CompareSecretsModal.tsx b/frontend/src/components/dashboard/CompareSecretsModal.tsx index 8c41ae8ca..b5d81bc04 100644 --- a/frontend/src/components/dashboard/CompareSecretsModal.tsx +++ b/frontend/src/components/dashboard/CompareSecretsModal.tsx @@ -1,6 +1,7 @@ import { SetStateAction, useEffect, useState } from 'react'; +import Image from 'next/image'; -import { WorkspaceEnv } from '~/pages/dashboard/[id]'; +import { WorkspaceEnv } from '@app/hooks/api/types'; import getSecretsForProject from '../utilities/secrets/getSecretsForProject'; import { Modal, ModalContent } from '../v2'; @@ -33,9 +34,10 @@ const CompareSecretsModal = ({ const [secrets, setSecrets] = useState([]); const getEnvSecrets = async () => { - const workspaceEnvironments = workspaceEnvs.filter((env) => env !== selectedEnv); + const workspaceEnvironments = workspaceEnvs?.filter((env) => env !== selectedEnv); const newSecrets = await Promise.all( workspaceEnvironments.map(async (env) => { + // #TODO: optimize this query somehow... const allSecrets = await getSecretsForProject({ env: env.slug, workspaceId }); const secret = allSecrets.find((item) => item.key === currentSecret.key)?.value ?? 'Not found'; @@ -57,16 +59,27 @@ const CompareSecretsModal = ({ e.preventDefault()}>
- {secrets.map((item) => ( -
-

{item.label}

- + infisical loading indicator
- ))} + ) : ( + secrets.map((item) => ( +
+

{item.label}

+ +
+ )) + )}
diff --git a/frontend/src/components/dashboard/SideBar.tsx b/frontend/src/components/dashboard/SideBar.tsx index d04055af0..d602e2c93 100644 --- a/frontend/src/components/dashboard/SideBar.tsx +++ b/frontend/src/components/dashboard/SideBar.tsx @@ -6,8 +6,7 @@ import { faX } from '@fortawesome/free-solid-svg-icons'; import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; import SecretVersionList from '@app/ee/components/SecretVersionList'; - -import { WorkspaceEnv } from '~/pages/dashboard/[id]'; +import { WorkspaceEnv } from '@app/hooks/api/types'; import Button from '../basic/buttons/Button'; import Toggle from '../basic/Toggle'; @@ -181,7 +180,7 @@ const SideBar = ({ /> )} -
+
) : (
-
loading animation
); diff --git a/frontend/src/pages/users/[id].tsx b/frontend/src/pages/users/[id].tsx index abd1cfc6f..27b531444 100644 --- a/frontend/src/pages/users/[id].tsx +++ b/frontend/src/pages/users/[id].tsx @@ -207,7 +207,6 @@ export default function Users() {
) : (
-
loading animation
);