From 56876a77e49de732bd65fb4a3c69f5c31229b37b Mon Sep 17 00:00:00 2001 From: Maidul Islam Date: Thu, 18 Apr 2024 16:03:11 -0400 Subject: [PATCH] correct comments phrase --- .../src/ee/services/dynamic-secret/providers/sql-database.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/src/ee/services/dynamic-secret/providers/sql-database.ts b/backend/src/ee/services/dynamic-secret/providers/sql-database.ts index e711e3c5b..4c1d5438b 100644 --- a/backend/src/ee/services/dynamic-secret/providers/sql-database.ts +++ b/backend/src/ee/services/dynamic-secret/providers/sql-database.ts @@ -13,7 +13,7 @@ import { DynamicSecretSqlDBSchema, SqlProviders, TDynamicProviderFns } from "./m const EXTERNAL_REQUEST_TIMEOUT = 10 * 1000; const generatePassword = (provider: SqlProviders) => { - // for now everyone else oracle can accept 48 password length + // oracle has limit of 48 password length const size = provider === SqlProviders.Oracle ? 30 : 48; const charset = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_.~!*$#"; @@ -21,7 +21,7 @@ const generatePassword = (provider: SqlProviders) => { }; const generateUsername = (provider: SqlProviders) => { - // for oracle without quotes in client it assumes everything is uppercase + // For oracle, the client assumes everything is upper case when not using quotes around the password if (provider === SqlProviders.Oracle) return alphaNumericNanoId(32).toUpperCase(); return alphaNumericNanoId(32);