From 97a0728f02937aa2ca1bdc525dddd48f3e137c66 Mon Sep 17 00:00:00 2001 From: Akhil Mohan Date: Tue, 8 Aug 2023 12:18:21 +0530 Subject: [PATCH] fix: secret path / with a new env causes secret list to be empty --- backend/src/controllers/v2/secretsController.ts | 8 +++++++- .../components/SecretDropzone/SecretDropzone.tsx | 4 +++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/backend/src/controllers/v2/secretsController.ts b/backend/src/controllers/v2/secretsController.ts index 284c69c09..e8cdb7837 100644 --- a/backend/src/controllers/v2/secretsController.ts +++ b/backend/src/controllers/v2/secretsController.ts @@ -697,10 +697,16 @@ export const getSecrets = async (req: Request, res: Response) => { const environment = req.query.environment as string; const folders = await Folder.findOne({ workspace: workspaceId, environment }); - if ((!folders && folderId && folderId !== "root") || (!folders && secretPath)) { + + if ( + // if no folders and asking for a non root folder id or non root secret path + (!folders && folderId && folderId !== "root") || + (!folders && secretPath && secretPath !== "/") + ) { res.send({ secrets: [] }); return; } + if (folders && folderId !== "root") { const folder = searchByFolderId(folders.nodes, folderId as string); if (!folder) { diff --git a/frontend/src/views/DashboardPage/components/SecretDropzone/SecretDropzone.tsx b/frontend/src/views/DashboardPage/components/SecretDropzone/SecretDropzone.tsx index 315eaf63a..6df9ab834 100644 --- a/frontend/src/views/DashboardPage/components/SecretDropzone/SecretDropzone.tsx +++ b/frontend/src/views/DashboardPage/components/SecretDropzone/SecretDropzone.tsx @@ -115,7 +115,9 @@ export const SecretDropzone = ({ workspaceId, env: selectedEnvSlug, secretPath: debouncedSecretPath, - isPaused: !(Boolean(workspaceId) && Boolean(selectedEnvSlug) && Boolean(debouncedSecretPath)), + isPaused: + !(Boolean(workspaceId) && Boolean(selectedEnvSlug) && Boolean(debouncedSecretPath)) && + !popUp.importSecEnv.isOpen, decryptFileKey });