feat: fixed eslint and resolved all eslint issues

backend/src/ee/services/secret-scanning/git-app-dal.ts

@@ -1,7 +1,7 @@
 import { Knex } from "knex";
 
 import { TDbClient } from "@app/db";
-import { TableName,TGitAppOrgInsert } from "@app/db/schemas";
+import { TableName, TGitAppOrgInsert } from "@app/db/schemas";
 import { DatabaseError } from "@app/lib/errors";
 import { ormify } from "@app/lib/knex";
 

backend/src/ee/services/secret-scanning/git-app-install-session-dal.ts

@@ -1,7 +1,7 @@
 import { Knex } from "knex";
 
 import { TDbClient } from "@app/db";
-import { TableName,TGitAppInstallSessionsInsert } from "@app/db/schemas";
+import { TableName, TGitAppInstallSessionsInsert } from "@app/db/schemas";
 import { DatabaseError } from "@app/lib/errors";
 import { ormify } from "@app/lib/knex";
 

backend/src/ee/services/secret-scanning/secret-scanning-dal.ts

@@ -1,7 +1,7 @@
 import { Knex } from "knex";
 
 import { TDbClient } from "@app/db";
-import { TableName,TSecretScanningGitRisksInsert } from "@app/db/schemas";
+import { TableName, TSecretScanningGitRisksInsert } from "@app/db/schemas";
 import { DatabaseError } from "@app/lib/errors";
 import { ormify } from "@app/lib/knex";
 

backend/src/ee/services/secret-scanning/secret-scanning-queue/secret-scanning-fns.ts

@@ -1,3 +1,4 @@
+import { Octokit } from "@octokit/rest";
 import { exec } from "child_process";
 import { mkdir, readFile, rm, writeFile } from "fs";
 import { tmpdir } from "os";
@@ -11,7 +12,7 @@ export function createTempFolder(): Promise<string> {
     const tempFolderName = Math.random().toString(36).substring(2);
     const tempFolderPath = join(tempDir, tempFolderName);
 
-    mkdir(tempFolderPath, (err: any) => {
+    mkdir(tempFolderPath, (err) => {
       if (err) {
         reject(err);
       } else {
@@ -115,7 +116,7 @@ export function convertKeysToLowercase<T>(obj: T): T {
 }
 
 export async function scanFullRepoContentAndGetFindings(
-  octokit: any,
+  octokit: Octokit,
   installationId: string,
   repositoryFullName: string
 ): Promise<SecretMatch[]> {
@@ -125,11 +126,13 @@ export async function scanFullRepoContentAndGetFindings(
   try {
     const {
       data: { token }
-    } = await octokit.apps.createInstallationAccessToken({ installation_id: installationId });
+    } = await octokit.apps.createInstallationAccessToken({
+      installation_id: Number(installationId)
+    });
     await cloneRepo(token, repositoryFullName, repoPath);
     await runInfisicalScanOnRepo(repoPath, findingsPath);
     const findingsData = await readFindingsFile(findingsPath);
-    return JSON.parse(findingsData);
+    return JSON.parse(findingsData) as SecretMatch[];
   } finally {
     await deleteTempFolder(tempFolder);
   }
@@ -144,7 +147,7 @@ export async function scanContentAndGetFindings(textContent: string): Promise<Se
     await writeTextToFile(filePath, textContent);
     await runInfisicalScan(filePath, findingsPath);
     const findingsData = await readFindingsFile(findingsPath);
-    return JSON.parse(findingsData);
+    return JSON.parse(findingsData) as SecretMatch[];
   } finally {
     await deleteTempFolder(tempFolder);
   }

backend/src/ee/services/secret-scanning/secret-scanning-queue/secret-scanning-queue.ts

@@ -96,8 +96,8 @@ export const secretScanningQueueFactory = ({
           path: filepath
         });
 
-        const { data }: any = fileContentsResponse;
-        const fileContent = Buffer.from(data.content, "base64").toString();
+        const { data } = fileContentsResponse;
+        const fileContent = Buffer.from((data as { content: string }).content, "base64").toString();
 
         // eslint-disable-next-line
         const findings = await scanContentAndGetFindings(`\n${fileContent}`); // extra line to count lines correctly
@@ -118,7 +118,7 @@ export const secretScanningQueueFactory = ({
     }
     await secretScanningDAL.transaction(async (tx) => {
       if (!Object.keys(allFindingsByFingerprint).length) return;
-      secretScanningDAL.upsert(
+      await secretScanningDAL.upsert(
         Object.keys(allFindingsByFingerprint).map((key) => ({
           installationId,
           email: allFindingsByFingerprint[key].Email,
@@ -186,7 +186,9 @@ export const secretScanningQueueFactory = ({
     });
 
     const findings = await scanFullRepoContentAndGetFindings(
-      octokit,
+      // this is because of collision of octokit in probot and github
+      // eslint-disable-next-line
+      octokit as any,
       installationId,
       repository.fullName
     );

backend/src/ee/services/secret-scanning/secret-scanning-service.ts

@@ -170,9 +170,7 @@ export const secretScanningServiceFactory = ({
     await secretScanningDAL.transaction(async (tx) => {
       if (repositoryIds.length) {
         await Promise.all(
-          repositoryIds.map((repoId) =>
-            secretScanningDAL.delete({ repositoryId: repoId }, tx)
-          )
+          repositoryIds.map((repoId) => secretScanningDAL.delete({ repositoryId: repoId }, tx))
         );
       }
       await gitAppOrgDAL.delete({ installationId }, tx);