misc: used promise all

This commit is contained in:
Sheen Capadngan
2025-07-26 03:26:24 +08:00
parent 7fdee073d8
commit 585cb1b30c
@@ -14,6 +14,7 @@ import { SecretMatch } from "@app/ee/services/secret-scanning/secret-scanning-qu
import { BITBUCKET_SECRET_SCANNING_DATA_SOURCE_LIST_OPTION } from "@app/ee/services/secret-scanning-v2/bitbucket"; import { BITBUCKET_SECRET_SCANNING_DATA_SOURCE_LIST_OPTION } from "@app/ee/services/secret-scanning-v2/bitbucket";
import { GITHUB_SECRET_SCANNING_DATA_SOURCE_LIST_OPTION } from "@app/ee/services/secret-scanning-v2/github"; import { GITHUB_SECRET_SCANNING_DATA_SOURCE_LIST_OPTION } from "@app/ee/services/secret-scanning-v2/github";
import { getConfig } from "@app/lib/config/env"; import { getConfig } from "@app/lib/config/env";
import { crypto } from "@app/lib/crypto";
import { BadRequestError } from "@app/lib/errors"; import { BadRequestError } from "@app/lib/errors";
import { titleCaseToCamelCase } from "@app/lib/fn"; import { titleCaseToCamelCase } from "@app/lib/fn";
@@ -184,25 +185,23 @@ export const scanSecretPolicyViolations = async (
const tempFolder = await createTempFolder(); const tempFolder = await createTempFolder();
try { try {
let iter = 0; const scanPromises = secrets
for await (const secret of secrets) { .filter((secret) => !ignoreKeys.includes(secret.secretKey))
if (ignoreKeys.includes(secret.secretKey)) { .map(async (secret) => {
// eslint-disable-next-line no-continue const secretFilePath = join(tempFolder, `${crypto.nativeCrypto.randomUUID()}.txt`);
continue; await writeTextToFile(secretFilePath, `${secret.secretKey}=${secret.secretValue}`);
}
iter += 1; try {
const secretFilePath = join(tempFolder, `${iter}.txt`); await scanFile(secretFilePath);
await writeTextToFile(secretFilePath, `${secret.secretKey}=${secret.secretValue}`); } catch (error) {
try { throw new BadRequestError({
await scanFile(secretFilePath); message: `Secret value detected in ${secret.secretKey}. Please add this instead to the designated secrets path in the project.`,
} catch (error) { name: "SecretPolicyViolation"
throw new BadRequestError({ });
message: `Secret value detected in ${secret.secretKey}. Please add this instead to the designated secrets path in the project.`, }
name: "SecretPolicyViolation" });
});
} await Promise.all(scanPromises);
}
} finally { } finally {
await deleteTempFolder(tempFolder); await deleteTempFolder(tempFolder);
} }