Lint

backend/src/ee/services/pki-acme/pki-acme-service.ts

@@ -687,7 +687,7 @@ export const pkiAcmeServiceFactory = ({
         const csrIdentifierValues = new Set(
           (certificateRequest.subjectAlternativeNames ?? [])
             .map((san) => san.value.toLowerCase())
-            .concat([certificateRequest.commonName!.toLowerCase()])
+            .concat([certificateRequest.commonName.toLowerCase()])
         );
         if (
           csrIdentifierValues.size !== orderWithAuthorizations.authorizations.length ||
@@ -727,7 +727,7 @@ export const pkiAcmeServiceFactory = ({
                 enrollmentType: EnrollmentType.ACME
               });
               return { certificateId: result.certificateId };
-            } else {
+            }
             const { certificateAuthority } = (await certificateProfileDAL.findByIdWithConfigs(profileId, tx))!;
             // TODO: for internal CA, we rely on the internal certificate authority service to check CSR against the template
             //       we should check the CSR against the template here
@@ -739,11 +739,7 @@ export const pkiAcmeServiceFactory = ({
                 commonName: certificateRequest.commonName!,
                 altNames: certificateRequest.subjectAlternativeNames?.map((san) => san.value),
                 // TODO: not 100% sure what are these columns for, but let's put the values for common website SSL certs for now
-                  keyUsages: [
+                keyUsages: [CertKeyUsage.DIGITAL_SIGNATURE, CertKeyUsage.KEY_ENCIPHERMENT, CertKeyUsage.KEY_AGREEMENT],
-                    CertKeyUsage.DIGITAL_SIGNATURE,
-                    CertKeyUsage.KEY_ENCIPHERMENT,
-                    CertKeyUsage.KEY_AGREEMENT
-                  ],
                 extendedKeyUsages: [CertExtendedKeyUsage.SERVER_AUTH]
               },
               {
@@ -758,7 +754,6 @@ export const pkiAcmeServiceFactory = ({
               }
             );
             return { certificateId: cert.id };
-            }
           })();
           await acmeOrderDAL.updateById(
             orderId,

backend/src/server/routes/v1/bdd-nock-router.ts

@@ -61,7 +61,7 @@ export const registerBddNockRouter = async (server: FastifyZodProvider) => {
       }
     },
     onRequest: verifyAuth([AuthMode.JWT]),
-    handler: async (req) => {
+    handler: async () => {
       checkIfBddNockApiEnabled();
       logger.info("Cleaning all nocks");
       nock.cleanAll();
@@ -78,7 +78,7 @@ export const registerBddNockRouter = async (server: FastifyZodProvider) => {
       }
     },
     onRequest: verifyAuth([AuthMode.JWT]),
-    handler: async (req) => {
+    handler: async () => {
       checkIfBddNockApiEnabled();
       logger.info("Restore network requests from nock");
       nock.restore();

backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.ts

@@ -337,8 +337,8 @@ export const orderCertificate = async (
         serialNumber: certObj.serialNumber,
         notBefore: certObj.notBefore,
         notAfter: certObj.notAfter,
-        keyUsages: keyUsages,
+        keyUsages,
-        extendedKeyUsages: extendedKeyUsages,
+        extendedKeyUsages,
         projectId: ca.projectId
       },
       innerTx