From 1567239fc222868da844b781f522fef9e041f597 Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Thu, 10 Jul 2025 16:05:37 -0700 Subject: [PATCH 1/2] improvement: use secret path input for create policy modal --- .../ApprovalPolicyList/components/AccessPolicyModal.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/AccessPolicyModal.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/AccessPolicyModal.tsx index 3c378cded..8cd42ccf5 100644 --- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/AccessPolicyModal.tsx +++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/AccessPolicyModal.tsx @@ -21,6 +21,7 @@ import { Tag, Tooltip } from "@app/components/v2"; +import { SecretPathInput } from "@app/components/v2/SecretPathInput"; import { useWorkspace } from "@app/context"; import { getMemberLabel } from "@app/helpers/members"; import { policyDetails } from "@app/helpers/policies"; @@ -202,6 +203,7 @@ const Form = ({ const formUserBypassers = watch("userBypassers"); const formGroupBypassers = watch("groupBypassers"); + const formEnvironment = watch("environment")?.slug; const bypasserCount = (formUserBypassers || []).length + (formGroupBypassers || []).length; const handleCreatePolicy = async ({ @@ -469,7 +471,7 @@ const Form = ({ errorText={error?.message} className="flex-1" > - + )} /> From af26323f3ba3c0c56f826201d657c0c3f3150d34 Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Fri, 11 Jul 2025 11:06:42 -0700 Subject: [PATCH 2/2] improvement: address feedback --- .../ApprovalPolicyList/components/AccessPolicyModal.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/AccessPolicyModal.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/AccessPolicyModal.tsx index 8cd42ccf5..7b1ecae19 100644 --- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/AccessPolicyModal.tsx +++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/AccessPolicyModal.tsx @@ -471,7 +471,11 @@ const Form = ({ errorText={error?.message} className="flex-1" > - + )} />