awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 19:28:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update/remove comments

Browse Source
This commit is contained in:
Tuan Dang
2024-08-05 20:19:14 -07:00
parent 8da8c6a66c
commit 5af53d3398
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/certificate-authority/certificate-authority-service.ts
+2 -3
View File
@@ -389,8 +389,6 @@ export const certificateAuthorityServiceFactory = ({
/** /**
* Renew certificate for CA with id [caId] * Renew certificate for CA with id [caId]
* Note: Currently implements CA renewal with same key-pair only * Note: Currently implements CA renewal with same key-pair only
*
* TODO: check rebuilt chain?
*/ */
const renewCaCert = async ({ caId, notAfter, actorId, actorAuthMethod, actor, actorOrgId }: TRenewCaCertDTO) => { const renewCaCert = async ({ caId, notAfter, actorId, actorAuthMethod, actor, actorOrgId }: TRenewCaCertDTO) => {
const ca = await certificateAuthorityDAL.findById(caId); const ca = await certificateAuthorityDAL.findById(caId);
@@ -950,7 +948,8 @@ export const certificateAuthorityServiceFactory = ({
plainText: Buffer.from(certificateChain) plainText: Buffer.from(certificateChain)
}); });
// TODO: validate that >latest< public-private key of CA is used to sign the certificate // TODO: validate that latest key-pair of CA is used to sign the certificate
// once renewal with new key pair is supported
const { caSecret, caPublicKey } = await getCaCredentials({ const { caSecret, caPublicKey } = await getCaCredentials({
caId: ca.id, caId: ca.id,
certificateAuthorityDAL, certificateAuthorityDAL,