From 5ba507bc1ca7c90ecaf930d9e09efb4ac4a12078 Mon Sep 17 00:00:00 2001
From: Sheen Capadngan <sheensantoscapadngan@gmail.com>
Date: Wed, 8 Jan 2025 19:17:38 +0800
Subject: [PATCH] misc: made installation ID optional for github

---
 .../AppConnections/GithubOauthCallbackPage/route.tsx            | 2 +-
 .../integrations/GithubOauthCallbackPage/route.tsx              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/src/pages/organization/AppConnections/GithubOauthCallbackPage/route.tsx b/frontend/src/pages/organization/AppConnections/GithubOauthCallbackPage/route.tsx
index 22c314765..889c30082 100644
--- a/frontend/src/pages/organization/AppConnections/GithubOauthCallbackPage/route.tsx
+++ b/frontend/src/pages/organization/AppConnections/GithubOauthCallbackPage/route.tsx
@@ -7,7 +7,7 @@ import { GitHubOAuthCallbackPage } from "./GithubOauthCallbackPage";
 const GitHubOAuthCallbackPageQueryParamsSchema = z.object({
   code: z.coerce.string().catch(""),
   state: z.string().catch(""),
-  installation_id: z.coerce.string().catch("")
+  installation_id: z.coerce.string().optional().catch("")
 });
 
 export const Route = createFileRoute(
diff --git a/frontend/src/pages/secret-manager/integrations/GithubOauthCallbackPage/route.tsx b/frontend/src/pages/secret-manager/integrations/GithubOauthCallbackPage/route.tsx
index 24b97d16e..fd08440a6 100644
--- a/frontend/src/pages/secret-manager/integrations/GithubOauthCallbackPage/route.tsx
+++ b/frontend/src/pages/secret-manager/integrations/GithubOauthCallbackPage/route.tsx
@@ -6,7 +6,7 @@ import { GithubOauthCallbackPage } from "./GithubOauthCallbackPage";
 
 export const GithubOAuthCallbackPageQueryParamsSchema = z.object({
   state: z.string().catch(""),
-  installation_id: z.coerce.string().catch(""),
+  installation_id: z.coerce.string().optional().catch(""),
   code: z.coerce.string().catch("")
 });