improvement: address feedback

This commit is contained in:
Scott Wilson
2025-02-21 07:51:15 -08:00
parent cb8528adc4
commit 5c08136fca
2 changed files with 84 additions and 105 deletions

View File

@@ -101,7 +101,7 @@ Infisical supports two methods for connecting to AWS.
]
}
```
<Note>If using a custom KMS key, be sure to add the IAM role as a key user. ![KMS Key IAM Role User](/images/app-connections/aws/kms-key-user.png)</Note>
<Note>If using a custom KMS key, be sure to add the IAM user or role as a key user. ![KMS Key IAM Role User](/images/app-connections/aws/kms-key-user.png)</Note>
</Accordion>
<Accordion title="AWS Parameter Store">
Use the following custom policy to grant the minimum permissions required by Infisical to sync secrets to AWS Parameter Store:
@@ -134,7 +134,7 @@ Infisical supports two methods for connecting to AWS.
]
}
```
<Note>If using a custom KMS key, be sure to add the IAM role as a key user. ![KMS Key IAM Role User](/images/app-connections/aws/kms-key-user.png)</Note>
<Note>If using a custom KMS key, be sure to add the IAM user or role as a key user. ![KMS Key IAM Role User](/images/app-connections/aws/kms-key-user.png)</Note>
</Accordion>
</AccordionGroup>
</Tab>
@@ -248,7 +248,7 @@ Infisical supports two methods for connecting to AWS.
]
}
```
<Note>If using a custom KMS key, be sure to add the IAM role as a key user. ![KMS Key IAM Role User](/images/app-connections/aws/kms-key-user.png)</Note>
<Note>If using a custom KMS key, be sure to add the IAM user or role as a key user. ![KMS Key IAM Role User](/images/app-connections/aws/kms-key-user.png)</Note>
</Accordion>
<Accordion title="AWS Parameter Store">
Use the following custom policy to grant the minimum permissions required by Infisical to sync secrets to AWS Parameter Store:
@@ -281,7 +281,7 @@ Infisical supports two methods for connecting to AWS.
]
}
```
<Note>If using a custom KMS key, be sure to add the IAM role as a key user. ![KMS Key IAM Role User](/images/app-connections/aws/kms-key-user.png)</Note>
<Note>If using a custom KMS key, be sure to add the IAM user or role as a key user. ![KMS Key IAM Role User](/images/app-connections/aws/kms-key-user.png)</Note>
</Accordion>
</AccordionGroup>
</Tab>

View File

@@ -7,7 +7,7 @@ import { zodResolver } from "@hookform/resolvers/zod";
import { twMerge } from "tailwind-merge";
import { createNotification } from "@app/components/notifications";
import { Button, FormControl, Modal, ModalContent, Switch } from "@app/components/v2";
import { Button, FormControl, Switch } from "@app/components/v2";
import { useWorkspace } from "@app/context";
import { SECRET_SYNC_MAP } from "@app/helpers/secretSyncs";
import {
@@ -165,7 +165,6 @@ export const CreateSecretSyncForm = ({ destination, onComplete, onCancel }: Prop
);
return (
<>
<form className={twMerge(isFinalStep && "max-h-[70vh] overflow-y-auto")}>
<FormProvider {...formMethods}>
<Tab.Group selectedIndex={selectedTabIndex} onChange={setSelectedTabIndex}>
@@ -248,25 +247,5 @@ export const CreateSecretSyncForm = ({ destination, onComplete, onCancel }: Prop
)}
</div>
</form>
<Modal isOpen={showConfirmation} onOpenChange={setShowConfirmation}>
<ModalContent
title="Import Secrets"
subTitle={`Import secrets into Infisical from this ${destinationName} Sync destination.`}
>
<div className="mt-6 flex flex-col rounded-sm border border-l-[2px] border-mineshaft-600 border-l-primary bg-mineshaft-700/80 px-4 py-3">
<div className="mb-1 flex items-center text-sm">
<FontAwesomeIcon icon={faInfoCircle} size="sm" className="mr-1.5 text-primary" />
Secret Sync Behavior
</div>
<p className="mb-2 mt-1 text-sm text-bunker-200">
Secret Syncs are the source of truth for connected third-party services. Any secret
not present or imported in Infisical before syncing will be overwritten, and changes
made directly in the connected service may also be overwritten by future syncs from
Infisical.
</p>
</div>
</ModalContent>
</Modal>
</>
);
};