awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 18:27:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed tests

Browse Source
This commit is contained in:
Daniel Hougaard
2024-09-27 20:02:43 +04:00
parent 55ca9149d5
commit 5ffb6b7232
3 changed files with 15 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/e2e-test/routes/v2/service-token.spec.ts
+3 -3
View File
@@ -510,7 +510,7 @@ describe("Service token fail cases", async () => {
authorization: `Bearer ${serviceToken}` authorization: `Bearer ${serviceToken}`
} }
}); });
expect(fetchSecrets.statusCode).toBe(401); expect(fetchSecrets.statusCode).toBe(403);
expect(fetchSecrets.json().error).toBe("PermissionDenied"); expect(fetchSecrets.json().error).toBe("PermissionDenied");
await deleteServiceToken(); await deleteServiceToken();
}); });
@@ -532,7 +532,7 @@ describe("Service token fail cases", async () => {
authorization: `Bearer ${serviceToken}` authorization: `Bearer ${serviceToken}`
} }
}); });
expect(fetchSecrets.statusCode).toBe(401); expect(fetchSecrets.statusCode).toBe(403);
expect(fetchSecrets.json().error).toBe("PermissionDenied"); expect(fetchSecrets.json().error).toBe("PermissionDenied");
await deleteServiceToken(); await deleteServiceToken();
}); });
@@ -557,7 +557,7 @@ describe("Service token fail cases", async () => {
authorization: `Bearer ${serviceToken}` authorization: `Bearer ${serviceToken}`
} }
}); });
expect(writeSecrets.statusCode).toBe(401); expect(writeSecrets.statusCode).toBe(403);
expect(writeSecrets.json().error).toBe("PermissionDenied"); expect(writeSecrets.json().error).toBe("PermissionDenied");
// but read access should still work fine // but read access should still work fine
backend/e2e-test/routes/v3/secrets.spec.ts
+3 -3
View File
@@ -1075,7 +1075,7 @@ describe("Secret V3 Raw Router Without E2EE enabled", async () => {
}, },
body: createSecretReqBody body: createSecretReqBody
}); });
expect(createSecRes.statusCode).toBe(400); expect(createSecRes.statusCode).toBe(404);
}); });
test("Update secret raw", async () => { test("Update secret raw", async () => {
@@ -1093,7 +1093,7 @@ describe("Secret V3 Raw Router Without E2EE enabled", async () => {
}, },
body: updateSecretReqBody body: updateSecretReqBody
}); });
expect(updateSecRes.statusCode).toBe(400); expect(updateSecRes.statusCode).toBe(404);
}); });
test("Delete secret raw", async () => { test("Delete secret raw", async () => {
@@ -1110,6 +1110,6 @@ describe("Secret V3 Raw Router Without E2EE enabled", async () => {
}, },
body: deletedSecretReqBody body: deletedSecretReqBody
}); });
expect(deletedSecRes.statusCode).toBe(400); expect(deletedSecRes.statusCode).toBe(404);
}); });
}); });
backend/src/server/routes/sanitizedSchemas.ts
+9 -19
View File
@@ -30,38 +30,28 @@ export const integrationAuthPubSchema = IntegrationAuthsSchema.pick({
export const DefaultResponseErrorsSchema = { export const DefaultResponseErrorsSchema = {
400: z.object({ 400: z.object({
statusCode: z.literal(400), statusCode: z.literal(400),
message: z.literal( message: z.string(),
`<string>: Contains a human-readable message about what went wrong. 400 errors are bad request errors, and are will occur to happen when passing or unexpected bad data in the request` error: z.string()
),
error: z.literal(`<string>: Contains a human-readable error name.`)
}), }),
404: z.object({ 404: z.object({
statusCode: z.literal(404), statusCode: z.literal(404),
message: z.literal( message: z.string(),
`<string>: Contains a human-readable message about what went wrong. 404 errors are not found errors, and will occur when a resource is not found` error: z.string()
),
error: z.literal(`<string>: Contains a human-readable error name.`)
}), }),
401: z.object({ 401: z.object({
statusCode: z.literal(401), statusCode: z.literal(401),
message: z.literal( message: z.string(),
`<string>: Contains a human-readable message about what went wrong. 401 errors are unauthorized errors, and will occur when attempting to access a resource with invalid or missing credentials` error: z.string()
),
error: z.literal(`<string>: Contains a human-readable error name.`)
}), }),
403: z.object({ 403: z.object({
statusCode: z.literal(403), statusCode: z.literal(403),
message: z.any(), message: z.any(),
error: z.literal( error: z.string()
`<string>: Contains a human-readable error name. The message can be both an object or a string. It will always be a string except if the error is happening due to a request validation error.`
)
}), }),
500: z.object({ 500: z.object({
statusCode: z.literal(500), statusCode: z.literal(500),
message: z.literal( message: z.string(),
`<string>: Contains a human-readable message about what went wrong. 500 errors are internal server errors, and will occur when an unexpected error occurs on the server` error: z.string()
),
error: z.literal(`<string>: Contains a human-readable error name.`)
}) })
}; };