From 606a5848f26eca17839755f4eb8ab1b94dd212ec Mon Sep 17 00:00:00 2001 From: Fang-Pen Lin Date: Fri, 21 Nov 2025 21:42:01 -0800 Subject: [PATCH] Add external ca cases for absent CN --- .../bdd/features/pki/acme/external-ca.feature | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/backend/bdd/features/pki/acme/external-ca.feature b/backend/bdd/features/pki/acme/external-ca.feature index e46acca3a..f809b3686 100644 --- a/backend/bdd/features/pki/acme/external-ca.feature +++ b/backend/bdd/features/pki/acme/external-ca.feature @@ -1,7 +1,7 @@ Feature: External CA @cloudflare - Scenario: Issue a certificate from an external CA with Cloudflare + Scenario Outline: Issue a certificate from an external CA with Cloudflare Given I create a Cloudflare connection as cloudflare Then I memorize cloudflare with jq ".appConnection.id" as app_conn_id Given I create a external ACME CA with the following config as ext_ca @@ -93,9 +93,7 @@ Feature: External CA When I create certificate signing request as csr Then I add names to certificate signing request csr """ - { - "COMMON_NAME": "localhost" - } + """ # Pebble has a strict rule to only takes SANs Then I add subject alternative name to certificate signing request csr @@ -180,8 +178,13 @@ Feature: External CA ] """ + Examples: + | subject | + | {"COMMON_NAME": "localhost"} | + | {} | + @dnsme - Scenario: Issue a certificate from an external CA with DNS Made Easy + Scenario Outline: Issue a certificate from an external CA with DNS Made Easy Given I create a DNS Made Easy connection as dnsme Then I memorize dnsme with jq ".appConnection.id" as app_conn_id Given I create a external ACME CA with the following config as ext_ca @@ -273,9 +276,7 @@ Feature: External CA When I create certificate signing request as csr Then I add names to certificate signing request csr """ - { - "COMMON_NAME": "localhost" - } + """ # Pebble has a strict rule to only takes SANs Then I add subject alternative name to certificate signing request csr @@ -362,4 +363,9 @@ Feature: External CA [ "localhost" ] - """ \ No newline at end of file + """ + + Examples: + | subject | + | {"COMMON_NAME": "localhost"} | + | {} |