improvement: address feedback

This commit is contained in:
Scott Wilson
2025-07-16 16:20:10 -07:00
parent 3fe41f81fe
commit 61ca617616
3 changed files with 32 additions and 35 deletions
@@ -1,5 +1,4 @@
import { Modal, ModalContent } from "@app/components/v2";
import { NoticeBannerV2 } from "@app/components/v2/NoticeBannerV2/NoticeBannerV2";
import { ProjectPermissionActions } from "@app/context";
import { TAccessApprovalPolicy } from "@app/hooks/api/types";
import { SpecificPrivilegeSecretForm } from "@app/pages/project/AccessControlPage/components/MembersTab/components/MemberRoleForm/SpecificPrivilegeSection";
@@ -8,7 +7,6 @@ export const RequestAccessModal = ({
isOpen,
onOpenChange,
policies,
shouldShowBanner,
...props
}: {
isOpen: boolean;
@@ -16,7 +14,6 @@ export const RequestAccessModal = ({
policies: TAccessApprovalPolicy[];
selectedActions?: ProjectPermissionActions[];
secretPath?: string;
shouldShowBanner?: boolean;
}) => {
return (
<Modal isOpen={isOpen} onOpenChange={onOpenChange}>
@@ -25,16 +22,6 @@ export const RequestAccessModal = ({
title="Request Access"
subTitle="Request access to any secrets and resources based on the predefined policies."
>
{shouldShowBanner && (
<NoticeBannerV2
className="mb-3"
title="You do not have permission to perform this action"
>
<p className="text-sm text-mineshaft-300">
Request access to perform this action in this folder.
</p>
</NoticeBannerV2>
)}
<SpecificPrivilegeSecretForm
onClose={() => onOpenChange(false)}
policies={policies}