From 62dbd3248a5c3e0895feccffd5b671e8af4e70c2 Mon Sep 17 00:00:00 2001 From: Fang-Pen Lin Date: Tue, 4 Nov 2025 16:57:07 -0800 Subject: [PATCH] More lint --- backend/src/ee/routes/v1/pki-acme-router.ts | 4 ++-- .../ee/services/pki-acme/pki-acme-challenge-dal.ts | 14 ++++++++------ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/backend/src/ee/routes/v1/pki-acme-router.ts b/backend/src/ee/routes/v1/pki-acme-router.ts index aa8f23766..b1419c086 100644 --- a/backend/src/ee/routes/v1/pki-acme-router.ts +++ b/backend/src/ee/routes/v1/pki-acme-router.ts @@ -36,7 +36,7 @@ export const registerPkiAcmeRouter = async (server: FastifyZodProvider) => { // eslint-disable-next-line @typescript-eslint/no-explicit-any R extends FastifyRequest, TSchema extends z.ZodSchema | undefined = undefined, - T = TSchema extends z.ZodSchema ? R : string + T = TSchema extends z.ZodSchema ? U : string >({ req, schema @@ -71,7 +71,7 @@ export const registerPkiAcmeRouter = async (server: FastifyZodProvider) => { if (!strBody) { done(null, undefined); } - const json = JSON.parse(strBody); + const json: unknown = JSON.parse(strBody); done(null, json); } catch (err) { const error = err as Error; diff --git a/backend/src/ee/services/pki-acme/pki-acme-challenge-dal.ts b/backend/src/ee/services/pki-acme/pki-acme-challenge-dal.ts index 424651aea..a07dc401d 100644 --- a/backend/src/ee/services/pki-acme/pki-acme-challenge-dal.ts +++ b/backend/src/ee/services/pki-acme/pki-acme-challenge-dal.ts @@ -35,8 +35,9 @@ export const pkiAcmeChallengeDALFactory = (db: TDbClient) => { ); // Update status for pending orders that have all auths valid await (tx || db)(TableName.PkiAcmeOrder) - .whereIn("id", (qb) => { - qb.select("o2.id") + .whereIn("id", async (qb) => { + void (await qb + .select("o2.id") .from({ o2: TableName.PkiAcmeOrder }) .join({ oa2: TableName.PkiAcmeOrderAuth }, "o2.id", "oa2.orderId") .join({ a2: TableName.PkiAcmeAuth }, "oa2.authId", "a2.id") @@ -47,7 +48,7 @@ export const pkiAcmeChallengeDALFactory = (db: TDbClient) => { ]) // Only update orders that are pending .where("o2.status", AcmeOrderStatus.Pending) - .whereIn("o2.id", involvedOrderIds); + .whereIn("o2.id", involvedOrderIds)); }) .update({ status: AcmeOrderStatus.Ready }); } @@ -74,8 +75,9 @@ export const pkiAcmeChallengeDALFactory = (db: TDbClient) => { if (updatedAuths.length > 0) { // Update status for pending orders that have all auths valid await (tx || db)(TableName.PkiAcmeOrder) - .whereIn("id", (qb) => { - qb.select("o.id") + .whereIn("id", async (qb) => { + void (await qb + .select("o.id") .from({ o: TableName.PkiAcmeOrder }) .join(TableName.PkiAcmeOrderAuth, "o.id", `${TableName.PkiAcmeOrderAuth}.orderId`) .join(TableName.PkiAcmeAuth, `${TableName.PkiAcmeOrderAuth}.authId`, `${TableName.PkiAcmeAuth}.id`) @@ -84,7 +86,7 @@ export const pkiAcmeChallengeDALFactory = (db: TDbClient) => { .whereIn( `${TableName.PkiAcmeAuth}.id`, updatedAuths.map((auth) => auth.id) - ); + )); }) .update({ status: AcmeOrderStatus.Invalid }); }