improvements: address feedback

backend/src/services/app-connection/app-connection-enums.ts

@@ -13,7 +13,7 @@ export enum AppConnection {
   Camunda = "camunda",
   Windmill = "windmill",
   Auth0 = "auth0",
-  Ldap = "ldap"
+  LDAP = "ldap"
 }
 
 export enum AWSRegion {

backend/src/services/app-connection/app-connection-fns.ts

@@ -138,7 +138,7 @@ export const validateAppConnectionCredentials = async (
     [AppConnection.TerraformCloud]: validateTerraformCloudConnectionCredentials as TAppConnectionCredentialsValidator,
     [AppConnection.Auth0]: validateAuth0ConnectionCredentials as TAppConnectionCredentialsValidator,
     [AppConnection.Windmill]: validateWindmillConnectionCredentials as TAppConnectionCredentialsValidator,
-    [AppConnection.Ldap]: validateLdapConnectionCredentials as TAppConnectionCredentialsValidator
+    [AppConnection.LDAP]: validateLdapConnectionCredentials as TAppConnectionCredentialsValidator
   };
 
   return VALIDATE_APP_CONNECTION_CREDENTIALS_MAP[appConnection.app](appConnection);
@@ -220,5 +220,5 @@ export const TRANSITION_CONNECTION_CREDENTIALS_TO_PLATFORM: Record<
   [AppConnection.Vercel]: platformManagedCredentialsNotSupported,
   [AppConnection.Windmill]: platformManagedCredentialsNotSupported,
   [AppConnection.Auth0]: platformManagedCredentialsNotSupported,
-  [AppConnection.Ldap]: platformManagedCredentialsNotSupported // we could support this in the future
+  [AppConnection.LDAP]: platformManagedCredentialsNotSupported // we could support this in the future
 };

backend/src/services/app-connection/app-connection-maps.ts

@@ -15,5 +15,5 @@ export const APP_CONNECTION_NAME_MAP: Record<AppConnection, string> = {
   [AppConnection.Camunda]: "Camunda",
   [AppConnection.Windmill]: "Windmill",
   [AppConnection.Auth0]: "Auth0",
-  [AppConnection.Ldap]: "LDAP"
+  [AppConnection.LDAP]: "LDAP"
 };

backend/src/services/app-connection/app-connection-service.ts

@@ -76,7 +76,7 @@ const VALIDATE_APP_CONNECTION_CREDENTIALS_MAP: Record<AppConnection, TValidateAp
   [AppConnection.Camunda]: ValidateCamundaConnectionCredentialsSchema,
   [AppConnection.Windmill]: ValidateWindmillConnectionCredentialsSchema,
   [AppConnection.Auth0]: ValidateAuth0ConnectionCredentialsSchema,
-  [AppConnection.Ldap]: ValidateLdapConnectionCredentialsSchema
+  [AppConnection.LDAP]: ValidateLdapConnectionCredentialsSchema
 };
 
 export const appConnectionServiceFactory = ({

backend/src/services/app-connection/ldap/ldap-connection-fns.ts

@@ -11,7 +11,7 @@ import { TLdapConnectionConfig } from "./ldap-connection-types";
 export const getLdapConnectionListItem = () => {
   return {
     name: "LDAP" as const,
-    app: AppConnection.Ldap as const,
+    app: AppConnection.LDAP as const,
     methods: Object.values(LdapConnectionMethod) as [LdapConnectionMethod.SimpleBind]
   };
 };

backend/src/services/app-connection/ldap/ldap-connection-schemas.ts

@@ -12,7 +12,12 @@ import { LdapConnectionMethod, LdapProvider } from "./ldap-connection-enums";
 
 export const LdapConnectionSimpleBindCredentialsSchema = z.object({
   provider: z.nativeEnum(LdapProvider).describe(AppConnections.CREDENTIALS.LDAP.provider),
-  url: z.string().trim().min(1, "URL required").describe(AppConnections.CREDENTIALS.LDAP.url),
+  url: z
+    .string()
+    .trim()
+    .min(1, "URL required")
+    .refine((value) => value.startsWith("ldap://") || value.startsWith("ldaps://"))
+    .describe(AppConnections.CREDENTIALS.LDAP.url),
   dn: z.string().trim().min(1, "Distinguished Name (DN) required").describe(AppConnections.CREDENTIALS.LDAP.dn),
   password: z.string().trim().min(1, "Password required").describe(AppConnections.CREDENTIALS.LDAP.password),
   sslRejectUnauthorized: z.boolean().optional().describe(AppConnections.CREDENTIALS.LDAP.sslRejectUnauthorized),
@@ -25,7 +30,7 @@ export const LdapConnectionSimpleBindCredentialsSchema = z.object({
 });
 
 const BaseLdapConnectionSchema = BaseAppConnectionSchema.extend({
-  app: z.literal(AppConnection.Ldap)
+  app: z.literal(AppConnection.LDAP)
 });
 
 export const LdapConnectionSchema = z.intersection(
@@ -54,28 +59,28 @@ export const SanitizedLdapConnectionSchema = z.discriminatedUnion("method", [
 
 export const ValidateLdapConnectionCredentialsSchema = z.discriminatedUnion("method", [
   z.object({
-    method: z.literal(LdapConnectionMethod.SimpleBind).describe(AppConnections.CREATE(AppConnection.Ldap).method),
+    method: z.literal(LdapConnectionMethod.SimpleBind).describe(AppConnections.CREATE(AppConnection.LDAP).method),
     credentials: LdapConnectionSimpleBindCredentialsSchema.describe(
-      AppConnections.CREATE(AppConnection.Ldap).credentials
+      AppConnections.CREATE(AppConnection.LDAP).credentials
     )
   })
 ]);
 
 export const CreateLdapConnectionSchema = ValidateLdapConnectionCredentialsSchema.and(
-  GenericCreateAppConnectionFieldsSchema(AppConnection.Ldap)
+  GenericCreateAppConnectionFieldsSchema(AppConnection.LDAP)
 );
 
 export const UpdateLdapConnectionSchema = z
   .object({
     credentials: LdapConnectionSimpleBindCredentialsSchema.optional().describe(
-      AppConnections.UPDATE(AppConnection.Ldap).credentials
+      AppConnections.UPDATE(AppConnection.LDAP).credentials
     )
   })
-  .and(GenericUpdateAppConnectionFieldsSchema(AppConnection.Ldap));
+  .and(GenericUpdateAppConnectionFieldsSchema(AppConnection.LDAP));
 
 export const LdapConnectionListItemSchema = z.object({
   name: z.literal("LDAP"),
-  app: z.literal(AppConnection.Ldap),
+  app: z.literal(AppConnection.LDAP),
   // the below is preferable but currently breaks with our zod to json schema parser
   // methods: z.tuple([z.literal(AwsConnectionMethod.ServicePrincipal), z.literal(AwsConnectionMethod.AccessKey)]),
   methods: z.nativeEnum(LdapConnectionMethod).array()

backend/src/services/app-connection/ldap/ldap-connection-types.ts

@@ -12,7 +12,7 @@ import {
 export type TLdapConnection = z.infer<typeof LdapConnectionSchema>;
 
 export type TLdapConnectionInput = z.infer<typeof CreateLdapConnectionSchema> & {
-  app: AppConnection.Ldap;
+  app: AppConnection.LDAP;
 };
 
 export type TValidateLdapConnectionCredentialsSchema = typeof ValidateLdapConnectionCredentialsSchema;