From 65f2e626aea0778b67e98d5249a4c1282ae88b74 Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Wed, 15 Jan 2025 22:37:20 -0800 Subject: [PATCH] chore: optimize import path, add comment context and removed commented out code --- frontend/src/components/secret-syncs/github/index.ts | 1 + frontend/src/context/OrgPermissionContext/types.ts | 1 + .../NativeIntegrationsTab/NativeIntegrationsTab.tsx | 4 ---- .../SecretSyncDestinationCol/GitHubSyncDestinationCol.tsx | 2 +- .../GitHubSyncDestinationSection.tsx | 2 +- 5 files changed, 4 insertions(+), 6 deletions(-) diff --git a/frontend/src/components/secret-syncs/github/index.ts b/frontend/src/components/secret-syncs/github/index.ts index e69de29bb..df66220b3 100644 --- a/frontend/src/components/secret-syncs/github/index.ts +++ b/frontend/src/components/secret-syncs/github/index.ts @@ -0,0 +1 @@ +export * from "./GitHubSyncSelectedRepositoriesTooltipContent"; diff --git a/frontend/src/context/OrgPermissionContext/types.ts b/frontend/src/context/OrgPermissionContext/types.ts index 4f93000df..3cf16507a 100644 --- a/frontend/src/context/OrgPermissionContext/types.ts +++ b/frontend/src/context/OrgPermissionContext/types.ts @@ -62,6 +62,7 @@ export type OrgPermissionSet = | [OrgPermissionActions, OrgPermissionSubjects.AuditLogs] | [OrgPermissionActions, OrgPermissionSubjects.ProjectTemplates] | [OrgPermissionActions, OrgPermissionSubjects.AppConnections]; +// TODO(scott): add back once org UI refactored // | [ // OrgPermissionAppConnectionActions, // ( diff --git a/frontend/src/pages/secret-manager/IntegrationsListPage/components/NativeIntegrationsTab/NativeIntegrationsTab.tsx b/frontend/src/pages/secret-manager/IntegrationsListPage/components/NativeIntegrationsTab/NativeIntegrationsTab.tsx index c70eb82aa..1479ac4bd 100644 --- a/frontend/src/pages/secret-manager/IntegrationsListPage/components/NativeIntegrationsTab/NativeIntegrationsTab.tsx +++ b/frontend/src/pages/secret-manager/IntegrationsListPage/components/NativeIntegrationsTab/NativeIntegrationsTab.tsx @@ -86,10 +86,6 @@ export const NativeIntegrationsTab = () => { isIntegrationsEmpty ]); - // useEffect(() => { - // setView(integrations?.length ? IntegrationView.List : IntegrationView.New); - // }, [isIntegrationsFetched]); - const handleProviderIntegration = async (provider: string) => { const selectedCloudIntegration = cloudIntegrations?.find(({ slug }) => provider === slug); if (!selectedCloudIntegration) return; diff --git a/frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncDestinationCol/GitHubSyncDestinationCol.tsx b/frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncDestinationCol/GitHubSyncDestinationCol.tsx index 211f92240..5c1b22fb1 100644 --- a/frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncDestinationCol/GitHubSyncDestinationCol.tsx +++ b/frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncDestinationCol/GitHubSyncDestinationCol.tsx @@ -1,4 +1,4 @@ -import { GitHubSyncSelectedRepositoriesTooltipContent } from "@app/components/secret-syncs/github/GitHubSyncSelectedRepositoriesTooltipContent"; +import { GitHubSyncSelectedRepositoriesTooltipContent } from "@app/components/secret-syncs/github"; import { GitHubSyncScope, GitHubSyncVisibility, diff --git a/frontend/src/pages/secret-manager/SecretSyncDetailsByIDPage/components/SecretSyncDestinationSection/GitHubSyncDestinationSection.tsx b/frontend/src/pages/secret-manager/SecretSyncDetailsByIDPage/components/SecretSyncDestinationSection/GitHubSyncDestinationSection.tsx index 191ad94a1..298fd3670 100644 --- a/frontend/src/pages/secret-manager/SecretSyncDetailsByIDPage/components/SecretSyncDestinationSection/GitHubSyncDestinationSection.tsx +++ b/frontend/src/pages/secret-manager/SecretSyncDetailsByIDPage/components/SecretSyncDestinationSection/GitHubSyncDestinationSection.tsx @@ -3,7 +3,7 @@ import { faInfoCircle } from "@fortawesome/free-solid-svg-icons"; import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; import { SecretSyncLabel } from "@app/components/secret-syncs"; -import { GitHubSyncSelectedRepositoriesTooltipContent } from "@app/components/secret-syncs/github/GitHubSyncSelectedRepositoriesTooltipContent"; +import { GitHubSyncSelectedRepositoriesTooltipContent } from "@app/components/secret-syncs/github"; import { Tooltip } from "@app/components/v2"; import { GitHubSyncScope,