From 66787b1f934af478fca02bcc12c450d103f49cbb Mon Sep 17 00:00:00 2001 From: Maidul Islam Date: Thu, 28 Sep 2023 23:08:47 -0700 Subject: [PATCH] fix secret scanning zod error for installationId --- .../src/queues/secret-scanning/githubScanFullRepository.ts | 5 +++-- backend/src/validation/secretScanning.ts | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/backend/src/queues/secret-scanning/githubScanFullRepository.ts b/backend/src/queues/secret-scanning/githubScanFullRepository.ts index eeb6aaf1e..c66bf2a2f 100644 --- a/backend/src/queues/secret-scanning/githubScanFullRepository.ts +++ b/backend/src/queues/secret-scanning/githubScanFullRepository.ts @@ -13,7 +13,7 @@ export const githubFullRepositorySecretScan = new Queue("github-full-repository- type TScanPushEventQueueDetails = { organizationId: string, - installationId: number, + installationId: string, repository: { id: number, fullName: string, @@ -30,7 +30,8 @@ githubFullRepositorySecretScan.process(async (job: Job, done: Queue.DoneCallback installationId: installationId }, }); - const findings: SecretMatch[] = await scanFullRepoContentAndGetFindings(octokit, installationId, repository.fullName) + + const findings: SecretMatch[] = await scanFullRepoContentAndGetFindings(octokit, installationId as any, repository.fullName) for (const finding of findings) { await GitRisks.findOneAndUpdate({ fingerprint: finding.Fingerprint }, { diff --git a/backend/src/validation/secretScanning.ts b/backend/src/validation/secretScanning.ts index e16c67c5c..2a883f8f8 100644 --- a/backend/src/validation/secretScanning.ts +++ b/backend/src/validation/secretScanning.ts @@ -6,7 +6,7 @@ export const CreateInstalLSessionv1 = z.object({ export const LinkInstallationToOrgv1 = z.object({ body: z.object({ - installationId: z.number(), + installationId: z.string(), sessionId: z.string().trim() }) });