feat: updated by reptile feedback

backend/src/ee/services/dynamic-secret/providers/aws-elasticache.ts

@@ -183,7 +183,12 @@ export const AwsElastiCacheDatabaseProvider = (): TDynamicProviderFns => {
     } catch (err) {
       const sanitizedErrorMessage = sanitizeString({
         unsanitizedString: (err as Error)?.message,
-        tokens: [providerInputs.accessKeyId, providerInputs.secretAccessKey, providerInputs.clusterName]
+        tokens: [
+          providerInputs.accessKeyId,
+          providerInputs.secretAccessKey,
+          providerInputs.clusterName,
+          providerInputs.region
+        ]
       });
       throw new BadRequestError({
         message: `Failed to connect with provider: ${sanitizedErrorMessage}`

backend/src/ee/services/dynamic-secret/providers/aws-iam.ts

@@ -180,47 +180,49 @@ export const AwsIamProvider = (): TDynamicProviderFns => {
       awsTags.push(...additionalTags);
     }
 
-    const createUserRes = await client.send(
+    try {
-      new CreateUserCommand({
+      const createUserRes = await client.send(
-        Path: awsPath,
+        new CreateUserCommand({
-        PermissionsBoundary: permissionBoundaryPolicyArn || undefined,
+          Path: awsPath,
-        Tags: awsTags,
+          PermissionsBoundary: permissionBoundaryPolicyArn || undefined,
-        UserName: username
+          Tags: awsTags,
-      })
+          UserName: username
-    );
-
-    if (!createUserRes.User) throw new BadRequestError({ message: "Failed to create AWS IAM User" });
-    if (userGroups) {
-      await Promise.all(
-        userGroups
-          .split(",")
-          .filter(Boolean)
-          .map((group) =>
-            client.send(new AddUserToGroupCommand({ UserName: createUserRes?.User?.UserName, GroupName: group }))
-          )
-      );
-    }
-    if (policyArns) {
-      await Promise.all(
-        policyArns
-          .split(",")
-          .filter(Boolean)
-          .map((policyArn) =>
-            client.send(new AttachUserPolicyCommand({ UserName: createUserRes?.User?.UserName, PolicyArn: policyArn }))
-          )
-      );
-    }
-    if (policyDocument) {
-      await client.send(
-        new PutUserPolicyCommand({
-          UserName: createUserRes.User.UserName,
-          PolicyName: `infisical-dynamic-policy-${alphaNumericNanoId(4)}`,
-          PolicyDocument: policyDocument
         })
       );
-    }
 
-    try {
+      if (!createUserRes.User) throw new BadRequestError({ message: "Failed to create AWS IAM User" });
+      if (userGroups) {
+        await Promise.all(
+          userGroups
+            .split(",")
+            .filter(Boolean)
+            .map((group) =>
+              client.send(new AddUserToGroupCommand({ UserName: createUserRes?.User?.UserName, GroupName: group }))
+            )
+        );
+      }
+      if (policyArns) {
+        await Promise.all(
+          policyArns
+            .split(",")
+            .filter(Boolean)
+            .map((policyArn) =>
+              client.send(
+                new AttachUserPolicyCommand({ UserName: createUserRes?.User?.UserName, PolicyArn: policyArn })
+              )
+            )
+        );
+      }
+      if (policyDocument) {
+        await client.send(
+          new PutUserPolicyCommand({
+            UserName: createUserRes.User.UserName,
+            PolicyName: `infisical-dynamic-policy-${alphaNumericNanoId(4)}`,
+            PolicyDocument: policyDocument
+          })
+        );
+      }
+
       const createAccessKeyRes = await client.send(
         new CreateAccessKeyCommand({
           UserName: createUserRes.User.UserName

backend/src/ee/services/dynamic-secret/providers/azure-entra-id.ts

@@ -114,12 +114,12 @@ export const AzureEntraIDProvider = (): TDynamicProviderFns & {
   };
 
   const revoke = async (inputs: unknown, entityId: string) => {
+    const providerInputs = await validateProviderInputs(inputs);
     try {
       // Creates a new password
       await create({ inputs });
       return { entityId };
     } catch (err) {
-      const providerInputs = await validateProviderInputs(inputs);
       const sanitizedErrorMessage = sanitizeString({
         unsanitizedString: (err as Error)?.message,
         tokens: [providerInputs.clientSecret, providerInputs.applicationId, entityId]

backend/src/ee/services/dynamic-secret/providers/elastic-search.ts

@@ -66,11 +66,7 @@ export const ElasticSearchProvider = (): TDynamicProviderFns => {
     const connection = await $getClient(providerInputs);
 
     try {
-      const infoResponse = await connection
+      const infoResponse = await connection.info().then(() => true);
-        .info()
-        .then(() => true)
-        .catch(() => false);
-
       return infoResponse;
     } catch (err) {
       const tokens = [];

backend/src/ee/services/dynamic-secret/providers/ldap.ts

@@ -216,7 +216,8 @@ export const LdapProvider = (): TDynamicProviderFns => {
     if (providerInputs.credentialType === LdapCredentialType.Static) {
       const dnRegex = new RE2("^dn:\\s*(.+)", "m");
       const dnMatch = dnRegex.exec(providerInputs.rotationLdif);
-      const username = dnMatch?.[1] || "";
+      const username = dnMatch?.[1];
+      if (!username) throw new BadRequestError({ message: "Username not found from Ldif" });
       const password = generatePassword();
 
       if (dnMatch) {

backend/src/ee/services/dynamic-secret/providers/redis.ts

@@ -123,7 +123,12 @@ export const RedisDatabaseProvider = (): TDynamicProviderFns => {
       if (connection) await connection.quit();
       const sanitizedErrorMessage = sanitizeString({
         unsanitizedString: (err as Error)?.message,
-        tokens: [providerInputs.password || "", providerInputs.username, providerInputs.host]
+        tokens: [
+          providerInputs.password || "",
+          providerInputs.username,
+          providerInputs.host,
+          String(providerInputs.port)
+        ]
       });
       throw new BadRequestError({
         message: `Failed to connect with provider: ${sanitizedErrorMessage}`

backend/src/ee/services/dynamic-secret/providers/snowflake.ts

@@ -155,7 +155,7 @@ export const SnowflakeProvider = (): TDynamicProviderFns => {
           sqlText: revokeStatement,
           complete(err) {
             if (err) {
-              return reject();
+              return reject(err);
             }
 
             return resolve(true);