feat: completed breadcrumb and settings changes

frontend/src/pages/secret-scanning/SecretScanningDataSourceByIdPage/route.tsx

@@ -13,12 +13,12 @@ export const Route = createFileRoute(
         {
           label: "Data Sources",
           link: linkOptions({
-            to: "/secret-scanning/$projectId/data-sources",
+            to: "/projects/$projectId/secret-scanning/data-sources",
             params
           })
         },
         {
-          label: "Data Source"
+          label: "Details"
         }
       ]
     };

frontend/src/pages/secret-scanning/SecretScanningDataSourcesPage/route.tsx

@@ -5,15 +5,15 @@ import { SecretScanningDataSourcesPage } from "./SecretScanningDataSourcesPage";
 export const Route = createFileRoute(
   "/_authenticate/_inject-org-details/_org-layout/projects/$projectId/_project-layout/secret-scanning/_secret-scanning-layout/data-sources/"
 )({
-  component: SecretScanningDataSourcesPage
-  // beforeLoad: ({ context }) => {
-  //   return {
-  //     breadcrumbs: [
-  //       ...context.breadcrumbs,
-  //       {
-  //         label: "Data Sources"
-  //       }
-  //     ]
-  //   };
-  // }
+  component: SecretScanningDataSourcesPage,
+  beforeLoad: ({ context }) => {
+    return {
+      breadcrumbs: [
+        ...context.breadcrumbs,
+        {
+          label: "Data Sources"
+        }
+      ]
+    };
+  }
 });

frontend/src/pages/secret-scanning/SettingsPage/SettingsPage.tsx

@@ -6,7 +6,6 @@ import { PageHeader, Tab, TabList, TabPanel, Tabs } from "@app/components/v2";
 import { ProjectPermissionSub } from "@app/context";
 import { ProjectPermissionSecretScanningConfigActions } from "@app/context/ProjectPermissionContext/types";
 
-import { ProjectGeneralTab } from "./components/ProjectGeneralTab";
 import { ProjectScanningConfigTab } from "./components/ProjectScanningConfigTab";
 
 export const SettingsPage = () => {
@@ -22,30 +21,16 @@ export const SettingsPage = () => {
         <Tabs defaultValue="tab-project-general">
           <TabList>
             <Tab value="tab-project-general">General</Tab>
+          </TabList>
+          <TabPanel value="tab-project-general">
             <ProjectPermissionCan
               I={ProjectPermissionSecretScanningConfigActions.Read}
               a={ProjectPermissionSub.SecretScanningConfigs}
+              renderGuardBanner
             >
-              {(isAllowed) =>
-                isAllowed && <Tab value="tab-project-scanning-config">Scanning Configuration</Tab>
-              }
+              <ProjectScanningConfigTab />
             </ProjectPermissionCan>
-          </TabList>
-          <TabPanel value="tab-project-general">
-            <ProjectGeneralTab />
           </TabPanel>
-          <ProjectPermissionCan
-            I={ProjectPermissionSecretScanningConfigActions.Read}
-            a={ProjectPermissionSub.SecretScanningConfigs}
-          >
-            {(isAllowed) =>
-              isAllowed && (
-                <TabPanel value="tab-project-scanning-config">
-                  <ProjectScanningConfigTab />
-                </TabPanel>
-              )
-            }
-          </ProjectPermissionCan>
         </Tabs>
       </div>
     </div>

frontend/src/pages/secret-scanning/layout.tsx

@@ -5,10 +5,5 @@ import { SecretScanningLayout } from "@app/layouts/SecretScanningLayout";
 export const Route = createFileRoute(
   "/_authenticate/_inject-org-details/_org-layout/projects/$projectId/_project-layout/secret-scanning/_secret-scanning-layout"
 )({
-  component: SecretScanningLayout,
-  beforeLoad: async () => {
-    return {
-      breadcrumbs: []
-    };
-  }
+  component: SecretScanningLayout
 });