Addressed PR suggestions

backend/src/services/secret-folder/secret-folder-service.ts

@@ -17,7 +17,7 @@ import { buildFolderPath } from "@app/services/secret-folder/secret-folder-fns";
 import {
   ChangeType,
   CommitType,
-  TCreateCommitChangeDTO,
+  TCommitResourceChangeDTO,
   TFolderCommitServiceFactory
 } from "../folder-commit/folder-commit-service";
 import { TProjectDALFactory } from "../project/project-dal";
@@ -251,15 +251,18 @@ export const secretFolderServiceFactory = ({
     folders,
     tx: providedTx,
     commitChanges
-  }: TUpdateManyFoldersDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[]; projectId?: string }) => {
+  }: TUpdateManyFoldersDTO & { tx?: Knex; commitChanges?: TCommitResourceChangeDTO[]; projectId?: string }) => {
     let projectId = providedProjectId;
-    if (!projectId) {
+    if (!projectId && projectSlug) {
       const project = await projectDAL.findProjectBySlug(projectSlug, actorOrgId);
       if (!project) {
         throw new NotFoundError({ message: `Project with slug '${projectSlug}' not found` });
       }
       projectId = project.id;
     }
+    if (!projectId) {
+      throw new BadRequestError({ message: "Must provide either project slug or projectId" });
+    }
 
     const { permission } = await permissionService.getProjectPermission({
       actor,
@@ -1010,7 +1013,7 @@ export const secretFolderServiceFactory = ({
     folders,
     tx: providedTx,
     commitChanges
-  }: TCreateManyFoldersDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[] }) => {
+  }: TCreateManyFoldersDTO & { tx?: Knex; commitChanges?: TCommitResourceChangeDTO[] }) => {
     const { permission } = await permissionService.getProjectPermission({
       actor,
       actorId,
@@ -1221,7 +1224,7 @@ export const secretFolderServiceFactory = ({
     folders,
     tx: providedTx,
     commitChanges
-  }: TDeleteManyFoldersDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[] }) => {
+  }: TDeleteManyFoldersDTO & { tx?: Knex; commitChanges?: TCommitResourceChangeDTO[] }) => {
     const { permission } = await permissionService.getProjectPermission({
       actor,
       actorId,

backend/src/services/secret-folder/secret-folder-types.ts

@@ -23,7 +23,7 @@ export type TUpdateFolderDTO = {
 } & TProjectPermission;
 
 export type TUpdateManyFoldersDTO = {
-  projectSlug: string;
+  projectSlug?: string;
   folders: {
     environment: string;
     path: string;
@@ -75,7 +75,7 @@ export type TCreateManyFoldersDTO = {
     name: string;
     environment: string;
     path: string;
-    description?: string;
+    description?: string | null;
   }>;
 };