mirror of
https://github.com/awatertrevi/infisical.git
synced 2026-10-07 12:27:28 +00:00
improvements: address feedback
This commit is contained in:
+1
-1
@@ -57,7 +57,7 @@ export const OrgGroupsSection = () => {
|
|||||||
return (
|
return (
|
||||||
<div className="mb-6 rounded-lg border border-mineshaft-600 bg-mineshaft-900 p-4">
|
<div className="mb-6 rounded-lg border border-mineshaft-600 bg-mineshaft-900 p-4">
|
||||||
<div className="mb-4 flex justify-between">
|
<div className="mb-4 flex justify-between">
|
||||||
<p className="text-xl font-semibold text-mineshaft-100">User Groups</p>
|
<p className="text-xl font-semibold text-mineshaft-100">Groups</p>
|
||||||
<OrgPermissionCan I={OrgPermissionActions.Create} a={OrgPermissionSubjects.Groups}>
|
<OrgPermissionCan I={OrgPermissionActions.Create} a={OrgPermissionSubjects.Groups}>
|
||||||
{(isAllowed) => (
|
{(isAllowed) => (
|
||||||
<Button
|
<Button
|
||||||
|
|||||||
+3
@@ -201,6 +201,9 @@ export const OrgMembersTable = ({ handlePopUpOpen, setCompleteInviteLinks }: Pro
|
|||||||
valueTwo = memberTwo.user.firstName;
|
valueTwo = memberTwo.user.firstName;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!valueOne) return 1;
|
||||||
|
if (!valueTwo) return -1;
|
||||||
|
|
||||||
return valueOne.toLowerCase().localeCompare(valueTwo.toLowerCase());
|
return valueOne.toLowerCase().localeCompare(valueTwo.toLowerCase());
|
||||||
}),
|
}),
|
||||||
[members, search, orderDirection, orderBy]
|
[members, search, orderDirection, orderBy]
|
||||||
|
|||||||
+6
-3
@@ -121,9 +121,12 @@ export const AddMemberModal = ({ popUp, handlePopUpToggle }: Props) => {
|
|||||||
});
|
});
|
||||||
return (orgUsers || [])
|
return (orgUsers || [])
|
||||||
.filter(({ user: u }) => !wsUserUsernames.has(u.username))
|
.filter(({ user: u }) => !wsUserUsernames.has(u.username))
|
||||||
.map((member) => ({
|
.map(({ id, inviteEmail, user: { firstName, lastName, email } }) => ({
|
||||||
value: member.id,
|
value: id,
|
||||||
label: `${member.user.firstName} ${member.user.lastName}`
|
label:
|
||||||
|
firstName && lastName
|
||||||
|
? `${firstName} ${lastName}`
|
||||||
|
: firstName || lastName || email || inviteEmail
|
||||||
}));
|
}));
|
||||||
}, [orgUsers, members]);
|
}, [orgUsers, members]);
|
||||||
|
|
||||||
|
|||||||
+3
@@ -118,6 +118,9 @@ export const MembersTable = ({ handlePopUpOpen }: Props) => {
|
|||||||
valueTwo = memberTwo.user.firstName;
|
valueTwo = memberTwo.user.firstName;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!valueOne) return 1;
|
||||||
|
if (!valueTwo) return -1;
|
||||||
|
|
||||||
return valueOne.toLowerCase().localeCompare(valueTwo.toLowerCase());
|
return valueOne.toLowerCase().localeCompare(valueTwo.toLowerCase());
|
||||||
}),
|
}),
|
||||||
[members, search, orderDirection, orderBy]
|
[members, search, orderDirection, orderBy]
|
||||||
|
|||||||
Reference in New Issue
Block a user