From 9d46c269d488492dcc3e42cb360737566447c4a9 Mon Sep 17 00:00:00 2001
From: ShubhamPalriwala <spalriwalau@gmail.com>
Date: Fri, 7 Jun 2024 13:05:04 +0530
Subject: [PATCH 1/2] fix: secret input on tab moves to next field and masks
 value

---
 frontend/src/components/v2/SecretInput/SecretInput.tsx    | 8 ++++++--
 .../ShareSecretPage/components/AddShareSecretModal.tsx    | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/frontend/src/components/v2/SecretInput/SecretInput.tsx b/frontend/src/components/v2/SecretInput/SecretInput.tsx
index 5e7bbef78..aca4d45d3 100644
--- a/frontend/src/components/v2/SecretInput/SecretInput.tsx
+++ b/frontend/src/components/v2/SecretInput/SecretInput.tsx
@@ -96,8 +96,12 @@ export const SecretInput = forwardRef<HTMLTextAreaElement, Props>(
             }}
             disabled={isDisabled}
             spellCheck={false}
-            onBlur={(evt) => {
-              onBlur?.(evt);
+            onKeyDown={(evt) => {
+              if (evt.key === "Tab") {
+                setIsSecretFocused.off();
+              }
+            }}
+            onBlur={() => {
               setIsSecretFocused.off();
             }}
             value={value || ""}
diff --git a/frontend/src/views/ShareSecretPage/components/AddShareSecretModal.tsx b/frontend/src/views/ShareSecretPage/components/AddShareSecretModal.tsx
index 2fda35be4..7ec9f95ad 100644
--- a/frontend/src/views/ShareSecretPage/components/AddShareSecretModal.tsx
+++ b/frontend/src/views/ShareSecretPage/components/AddShareSecretModal.tsx
@@ -178,7 +178,7 @@ export const AddShareSecretModal = ({ popUp, handlePopUpToggle }: Props) => {
                   errorText={error?.message}
                 >
                   <SecretInput
-                    isVisible
+                    isVisible={false}
                     {...field}
                     containerClassName="py-1.5 rounded-md transition-all group-hover:mr-2 text-bunker-300 hover:border-primary-400/50 border border-mineshaft-600 bg-mineshaft-900 px-2 min-h-[100px]"
                   />

From e5b7ebbabfdde6cd3080b925ee4cdb124ebffb73 Mon Sep 17 00:00:00 2001
From: ShubhamPalriwala <spalriwalau@gmail.com>
Date: Sat, 8 Jun 2024 05:47:47 +0530
Subject: [PATCH 2/2] revert: change in core component

---
 frontend/src/components/v2/SecretInput/SecretInput.tsx | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/frontend/src/components/v2/SecretInput/SecretInput.tsx b/frontend/src/components/v2/SecretInput/SecretInput.tsx
index aca4d45d3..5e7bbef78 100644
--- a/frontend/src/components/v2/SecretInput/SecretInput.tsx
+++ b/frontend/src/components/v2/SecretInput/SecretInput.tsx
@@ -96,12 +96,8 @@ export const SecretInput = forwardRef<HTMLTextAreaElement, Props>(
             }}
             disabled={isDisabled}
             spellCheck={false}
-            onKeyDown={(evt) => {
-              if (evt.key === "Tab") {
-                setIsSecretFocused.off();
-              }
-            }}
-            onBlur={() => {
+            onBlur={(evt) => {
+              onBlur?.(evt);
               setIsSecretFocused.off();
             }}
             value={value || ""}