From 6cf248832666dc2bcfa8b7757f3ba4fa25420fb6 Mon Sep 17 00:00:00 2001
From: McPizza0 <gh@mcadam.io>
Date: Tue, 26 Nov 2024 23:22:07 +0100
Subject: [PATCH] Fix(Azure Key Vault): Ignore disabled secrets

---
 .../integration-sync-secret.ts                | 32 ++++++++++++-------
 1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/backend/src/services/integration-auth/integration-sync-secret.ts b/backend/src/services/integration-auth/integration-sync-secret.ts
index 3983bd8bc..3ed2887fa 100644
--- a/backend/src/services/integration-auth/integration-sync-secret.ts
+++ b/backend/src/services/integration-auth/integration-sync-secret.ts
@@ -516,12 +516,18 @@ const syncSecretsAzureKeyVault = async ({
         if (!lastSlashIndex) {
           lastSlashIndex = getAzureKeyVaultSecret.id.lastIndexOf("/");
         }
+        if (!getAzureKeyVaultSecret.attributes.enabled) return null;
 
-        const azureKeyVaultSecret = await request.get(`${getAzureKeyVaultSecret.id}?api-version=7.3`, {
-          headers: {
-            Authorization: `Bearer ${accessToken}`
-          }
-        });
+        let azureKeyVaultSecret;
+        try {
+          azureKeyVaultSecret = await request.get(`${getAzureKeyVaultSecret.id}?api-version=7.3`, {
+            headers: {
+              Authorization: `Bearer ${accessToken}`
+            }
+          });
+        } catch (err) {
+          throw new Error(`Failed to fetch Azure Key Vault secret: ${(err as Error).message}`);
+        }
 
         return {
           ...azureKeyVaultSecret.data,
@@ -529,13 +535,15 @@ const syncSecretsAzureKeyVault = async ({
         };
       })
     )
-  ).reduce(
-    (obj, secret) => ({
-      ...obj,
-      [secret.key]: secret
-    }),
-    {}
-  );
+  )
+    .filter((secret) => secret !== null)
+    .reduce(
+      (obj, secret) => ({
+        ...obj,
+        [secret.key]: secret
+      }),
+      {}
+    );
 
   const setSecrets: {
     key: string;