diff --git a/frontend/src/pages/organization/SettingsPage/components/OrgAuthTab/OrgAuthTab.tsx b/frontend/src/pages/organization/SettingsPage/components/OrgAuthTab/OrgAuthTab.tsx index cc6358e3c..40d0e7840 100644 --- a/frontend/src/pages/organization/SettingsPage/components/OrgAuthTab/OrgAuthTab.tsx +++ b/frontend/src/pages/organization/SettingsPage/components/OrgAuthTab/OrgAuthTab.tsx @@ -45,6 +45,7 @@ export const OrgAuthTab = withPermission( const { data: samlConfig, isPending: isLoadingSamlConfig } = useGetSSOConfig( currentOrg?.id ?? "" ); + const { data: ldapConfig, isPending: isLoadingLdapConfig } = useGetLDAPConfig( currentOrg?.id ?? "" ); @@ -54,7 +55,8 @@ export const OrgAuthTab = withPermission( !enabledLoginMethods || enabledLoginMethods.includes(method); const isOidcConfigured = oidcConfig && (oidcConfig.discoveryURL || oidcConfig.issuer); - const isSamlConfigured = samlConfig && samlConfig.entryPoint; + const isSamlConfigured = + samlConfig && (samlConfig.entryPoint || samlConfig.issuer || samlConfig.cert); const isLdapConfigured = ldapConfig && ldapConfig.url; const shouldShowCreateIdentityProviderView = diff --git a/frontend/src/pages/organization/SettingsPage/components/OrgAuthTab/SSOModal.tsx b/frontend/src/pages/organization/SettingsPage/components/OrgAuthTab/SSOModal.tsx index 32fa681e2..c38ec6889 100644 --- a/frontend/src/pages/organization/SettingsPage/components/OrgAuthTab/SSOModal.tsx +++ b/frontend/src/pages/organization/SettingsPage/components/OrgAuthTab/SSOModal.tsx @@ -63,7 +63,7 @@ const ssoAuthProviders = [ const schema = z .object({ authProvider: z.string().min(1, "SSO Type is required"), - entryPoint: z.string().default(""), + entryPoint: z.string().min(1, "Entry Point is required").default(""), issuer: z.string().default(""), cert: z.string().default("") }) @@ -301,6 +301,7 @@ export const SSOModal = ({ popUp, handlePopUpClose, handlePopUpToggle, hideDelet label={renderLabels(authProvider).entryPoint} errorText={error?.message} isError={Boolean(error)} + isRequired >