From c2e326b95a302cd62d6f60d3299f08dc97f96a5f Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Thu, 10 Jul 2025 15:02:38 -0700 Subject: [PATCH] fix: remove jim as sole author of all secret leaks --- .../secret-scanning-v2/secret-scanning-v2-queue.ts | 12 ++++++++---- .../secret-scanning-v2/secret-scanning-v2-types.ts | 9 ++++++++- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-queue.ts b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-queue.ts index 417417c74..137034feb 100644 --- a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-queue.ts +++ b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-queue.ts @@ -37,7 +37,8 @@ import { TQueueSecretScanningDataSourceFullScan, TQueueSecretScanningResourceDiffScan, TQueueSecretScanningSendNotification, - TSecretScanningDataSourceWithConnection + TSecretScanningDataSourceWithConnection, + TSecretScanningFinding } from "./secret-scanning-v2-types"; type TSecretRotationV2QueueServiceFactoryDep = { @@ -459,13 +460,16 @@ export const secretScanningV2QueueServiceFactory = async ({ const newFindings = allFindings.filter((finding) => finding.scanId === scanId); if (newFindings.length) { + const finding = newFindings[0] as TSecretScanningFinding; await queueService.queuePg(QueueJobs.SecretScanningV2SendNotification, { status: SecretScanningScanStatus.Completed, resourceName: resource.name, isDiffScan: true, dataSource, numberOfSecrets: newFindings.length, - scanId + scanId, + authorName: finding?.details?.author, + authorEmail: finding?.details?.email }); } @@ -582,8 +586,8 @@ export const secretScanningV2QueueServiceFactory = async ({ substitutions: payload.status === SecretScanningScanStatus.Completed ? { - authorName: "Jim", - authorEmail: "jim@infisical.com", + authorName: payload.authorName, + authorEmail: payload.authorEmail, resourceName, numberOfSecrets: payload.numberOfSecrets, isDiffScan: payload.isDiffScan, diff --git a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-types.ts b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-types.ts index 35486bd59..6bd8251b6 100644 --- a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-types.ts +++ b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-types.ts @@ -119,7 +119,14 @@ export type TQueueSecretScanningSendNotification = { resourceName: string; } & ( | { status: SecretScanningScanStatus.Failed; errorMessage: string } - | { status: SecretScanningScanStatus.Completed; numberOfSecrets: number; scanId: string; isDiffScan: boolean } + | { + status: SecretScanningScanStatus.Completed; + numberOfSecrets: number; + scanId: string; + isDiffScan: boolean; + authorName?: string; + authorEmail?: string; + } ); export type TCloneRepository = {