improvements: address feedback, feature docs and cert validation with dns rebinding handling

frontend/src/pages/secret-manager/SecretDashboardPage/components/SnapshotView/SnapshotView.tsx

@@ -33,13 +33,11 @@ type Props = {
 const LOADER_TEXT = ["Fetching your snapshot", "Creating the difference view"];
 
 const deepCompareSecrets = (lhs: SecretV3RawSanitized, rhs: SecretV3RawSanitized) =>
-  lhs.isRotatedSecret ||
-  rhs.isRotatedSecret ||
-  (lhs.key === rhs.key &&
-    lhs.value === rhs.value &&
-    lhs.comment === rhs.comment &&
-    lhs?.valueOverride === rhs?.valueOverride &&
-    JSON.stringify(lhs.tags) === JSON.stringify(rhs.tags));
+  lhs.key === rhs.key &&
+  lhs.value === rhs.value &&
+  lhs.comment === rhs.comment &&
+  lhs?.valueOverride === rhs?.valueOverride &&
+  JSON.stringify(lhs.tags) === JSON.stringify(rhs.tags);
 
 export const SnapshotView = ({
   snapshotId,
@@ -100,9 +98,12 @@ export const SnapshotView = ({
       const doesExist = Boolean(secretGroupById?.[id]);
       if (doesExist) {
         diffView.push({
-          mode: deepCompareSecrets(rollSecret, secretGroupById[id])
-            ? TDiffModes.NoChange
-            : TDiffModes.Modified,
+          mode:
+            rollSecret.isRotatedSecret ||
+            secretGroupById[id]?.isRotatedSecret ||
+            deepCompareSecrets(rollSecret, secretGroupById[id])
+              ? TDiffModes.NoChange
+              : TDiffModes.Modified,
           pre: secretGroupById[id],
           post: rollSecret
         });

frontend/src/pages/secret-manager/SecretRotationPage/SecretRotationPage.tsx

@@ -141,7 +141,7 @@ const Page = () => {
       </PageHeader>
       <NoticeBannerV2 title="Secret Rotations Update">
         <p className="text-sm text-bunker-200">
-          Infisical is revamping it&#39;s Secret Rotation experience.
+          Infisical is revamping its Secret Rotation experience.
         </p>
         <p className="mt-2 text-sm text-bunker-200">
           Secret Rotations can now be created from the{" "}
@@ -364,7 +364,7 @@ const Page = () => {
         <ModalContent className="max-w-5xl" title="Secret Rotation Update">
           <div className="flex flex-col gap-2">
             <p className="text-mineshaft-200">
-              Infisical is revamping it&#39;s Secret Rotation experience. Navigate to the{" "}
+              Infisical is revamping its Secret Rotation experience. Navigate to the{" "}
               <Link
                 className="text-mineshaft-100 underline decoration-primary underline-offset-2 hover:text-mineshaft-200"
                 to={`/${ProjectType.SecretManager}/$projectId/overview` as const}
@@ -372,7 +372,7 @@ const Page = () => {
               >
                 Secret Manager Dashboard
               </Link>{" "}
-              to create a Secret Rotations.
+              to create a Secret Rotation.
             </p>
             <div className="overflow-clip rounded border border-mineshaft-600">
               <img