From f3908e6b2add76a07b9e0412450eeb90513da175 Mon Sep 17 00:00:00 2001 From: Akhil Mohan Date: Tue, 3 Oct 2023 20:14:43 +0530 Subject: [PATCH] fix: resolved permission check on imported secrets when using service token --- backend/src/controllers/v3/secretsController.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/backend/src/controllers/v3/secretsController.ts b/backend/src/controllers/v3/secretsController.ts index 451de1294..b388f8305 100644 --- a/backend/src/controllers/v3/secretsController.ts +++ b/backend/src/controllers/v3/secretsController.ts @@ -3,7 +3,7 @@ import { Types } from "mongoose"; import { EventService, SecretService } from "../../services"; import { eventPushSecrets } from "../../events"; import { BotService } from "../../services"; -import { containsGlobPatterns, isValidScope, repackageSecretToRaw } from "../../helpers/secrets"; +import { containsGlobPatterns, repackageSecretToRaw } from "../../helpers/secrets"; import { encryptSymmetric128BitHexKeyUTF8 } from "../../utils/crypto"; import { getAllImportedSecrets } from "../../services/SecretImportService"; import { Folder, IServiceTokenData } from "../../models"; @@ -81,8 +81,7 @@ export const getSecretsRaw = async (req: Request, res: Response) => { secretPath, requiredPermissions: [PERMISSION_READ_SECRETS] }); - permissionCheckFn = (env: string, secPath: string) => - isValidScope(req.authData.authPayload as IServiceTokenData, env, secPath); + permissionCheckFn = () => true; } const secrets = await SecretService.getSecrets({ @@ -447,8 +446,7 @@ export const getSecrets = async (req: Request, res: Response) => { secretPath, requiredPermissions: [PERMISSION_READ_SECRETS] }); - permissionCheckFn = (env: string, secPath: string) => - isValidScope(req.authData.authPayload as IServiceTokenData, env, secPath); + permissionCheckFn = () => true; } const secrets = await SecretService.getSecrets({