awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 01:27:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resolve review comments

Browse Source
This commit is contained in:
Joel Biddle
2023-10-04 04:50:16 +00:00
parent 390c2cc4d9
commit 726f38c15f
2 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/build-docker-image-to-prod.yml
+2 -10
View File
@@ -40,9 +40,7 @@ jobs:
load: true load: true
context: backend context: backend
tags: | tags: |
infisical/backend:${{ steps.extract_version.outputs.version }} infisical/backend:test
labels: |
version=${{ steps.extract_version.outputs.version }}
- name: ⏻ Spawn backend container and dependencies - name: ⏻ Spawn backend container and dependencies
run: | run: |
docker compose -f .github/resources/docker-compose.be-test.yml up --wait --quiet-pull docker compose -f .github/resources/docker-compose.be-test.yml up --wait --quiet-pull
@@ -63,8 +61,6 @@ jobs:
infisical/backend:${{ steps.commit.outputs.short }} infisical/backend:${{ steps.commit.outputs.short }}
infisical/backend:${{ steps.extract_version.outputs.version }} infisical/backend:${{ steps.extract_version.outputs.version }}
platforms: linux/amd64,linux/arm64 platforms: linux/amd64,linux/arm64
labels: |
version=${{ steps.extract_version.outputs.version }}
frontend-image: frontend-image:
name: Build frontend image name: Build frontend image
@@ -95,12 +91,10 @@ jobs:
project: 64mmf0n610 project: 64mmf0n610
context: frontend context: frontend
tags: | tags: |
infisical/frontend:${{ steps.extract_version.outputs.version }} infisical/frontend:test
build-args: | build-args: |
POSTHOG_API_KEY=${{ secrets.PUBLIC_POSTHOG_API_KEY }} POSTHOG_API_KEY=${{ secrets.PUBLIC_POSTHOG_API_KEY }}
NEXT_INFISICAL_PLATFORM_VERSION=${{ steps.extract_version.outputs.version }} NEXT_INFISICAL_PLATFORM_VERSION=${{ steps.extract_version.outputs.version }}
labels: |
version=${{ steps.extract_version.outputs.version }}
- name: ⏻ Spawn frontend container - name: ⏻ Spawn frontend container
run: | run: |
docker run -d --rm --name infisical-frontend-test infisical/frontend:test docker run -d --rm --name infisical-frontend-test infisical/frontend:test
@@ -124,5 +118,3 @@ jobs:
build-args: | build-args: |
POSTHOG_API_KEY=${{ secrets.PUBLIC_POSTHOG_API_KEY }} POSTHOG_API_KEY=${{ secrets.PUBLIC_POSTHOG_API_KEY }}
NEXT_INFISICAL_PLATFORM_VERSION=${{ steps.extract_version.outputs.version }} NEXT_INFISICAL_PLATFORM_VERSION=${{ steps.extract_version.outputs.version }}
labels: |
version=${{ steps.extract_version.outputs.version }}
frontend/src/layouts/AppLayout/AppLayout.tsx
+7 -4
View File
@@ -123,6 +123,7 @@ export const AppLayout = ({ children }: LayoutProps) => {
const createWs = useCreateWorkspace(); const createWs = useCreateWorkspace();
const uploadWsKey = useUploadWsKey(); const uploadWsKey = useUploadWsKey();
const addWsUser = useAddUserToWs(); const addWsUser = useAddUserToWs();
const infisicalPlatformVersion = process.env.NEXT_PUBLIC_INFISICAL_PLATFORM_VERSION;
const { popUp, handlePopUpOpen, handlePopUpClose, handlePopUpToggle } = usePopUp([ const { popUp, handlePopUpOpen, handlePopUpClose, handlePopUpToggle } = usePopUp([
"addNewWs", "addNewWs",
@@ -697,10 +698,12 @@ export const AppLayout = ({ children }: LayoutProps) => {
</div> </div>
</button> </button>
)} )}
<div className="mb-2 w-full pl-5 duration-200 hover:text-mineshaft-200"> {infisicalPlatformVersion && (
<FontAwesomeIcon icon={faInfo} className="mr-4 px-[0.1rem]" /> <div className="mb-2 w-full pl-5 duration-200 hover:text-mineshaft-200">
Platform Version: {process.env.NEXT_PUBLIC_INFISICAL_PLATFORM_VERSION || "N/A"} <FontAwesomeIcon icon={faInfo} className="mr-4 px-[0.1rem]" />
</div> Platform Version: {infisicalPlatformVersion}
</div>
)}
</div> </div>
</nav> </nav>
</aside> </aside>