Resolve PR review issues

backend/src/ee/routes/v1/group-router.ts

@@ -13,7 +13,7 @@ export const registerGroupRouter = async (server: FastifyZodProvider) => {
     onRequest: verifyAuth([AuthMode.JWT]),
     schema: {
       body: z.object({
-        name: z.string().trim().min(1).describe(GROUPS.CREATE.name),
+        name: z.string().trim().min(1).max(50).describe(GROUPS.CREATE.name),
         slug: z
           .string()
           .min(5)

backend/src/ee/services/group/group-dal.ts

@@ -118,9 +118,8 @@ export const groupDALFactory = (db: TDbClient) => {
           db.ref("firstName").withSchema(TableName.Users),
           db.ref("lastName").withSchema(TableName.Users),
           db.ref("id").withSchema(TableName.Users).as("userId")
-          // db.raw(`CASE WHEN "${TableName.UserGroupMembership}"."groupId" IS NOT NULL THEN TRUE ELSE FALSE END as isPartOfGroup`)
         )
-        .where({ isGhost: false }) // MAKE SURE USER IS NOT A GHOST USER
+        .where({ isGhost: false })
         .offset(offset);
 
       if (limit) {

backend/src/ee/services/license/__mocks__/licence-fns.ts

@@ -12,15 +12,15 @@ export const getDefaultOnPremFeatures = () => {
     secretVersioning: true,
     pitRecovery: false,
     ipAllowlisting: true,
-    rbac: true,
+    rbac: false,
     customRateLimits: false,
     customAlerts: false,
     auditLogs: false,
     auditLogsRetentionDays: 0,
-    samlSSO: true,
-    scim: true,
+    samlSSO: false,
+    scim: false,
     ldap: false,
-    groups: true,
+    groups: false,
     status: null,
     trial_end: null,
     has_used_trial: true,

backend/src/ee/services/license/licence-fns.ts

@@ -19,15 +19,15 @@ export const getDefaultOnPremFeatures = (): TFeatureSet => ({
   secretVersioning: true,
   pitRecovery: false,
   ipAllowlisting: false,
-  rbac: true,
+  rbac: false,
   customRateLimits: false,
   customAlerts: false,
   auditLogs: false,
   auditLogsRetentionDays: 0,
-  samlSSO: true,
-  scim: true,
+  samlSSO: false,
+  scim: false,
   ldap: false,
-  groups: true,
+  groups: false,
   status: null,
   trial_end: null,
   has_used_trial: true,

backend/src/ee/services/license/license-types.ts

@@ -35,15 +35,15 @@ export type TFeatureSet = {
   secretVersioning: true;
   pitRecovery: false;
   ipAllowlisting: false;
-  rbac: true;
+  rbac: false;
   customRateLimits: false;
   customAlerts: false;
   auditLogs: false;
   auditLogsRetentionDays: 0;
-  samlSSO: true;
-  scim: true;
+  samlSSO: false;
+  scim: false;
   ldap: false;
-  groups: true;
+  groups: false;
   status: null;
   trial_end: null;
   has_used_trial: true;