patch project identity update

backend/.eslintrc.js

@@ -38,6 +38,7 @@ module.exports = {
     "@typescript-eslint/no-empty-function": "off",
     "@typescript-eslint/no-unsafe-enum-comparison": "off",
     "no-void": "off",
+    "no-await-in-loop": "off",
     "consistent-return": "off", // my style
     "import/order": "off", // for simple-import-order
     "import/prefer-default-export": "off", // why

backend/src/services/identity-project/identity-project-service.ts

@@ -82,6 +82,7 @@ export const identityProjectServiceFactory = ({
       role,
       project.id
     );
+
     const hasPriviledge = isAtLeastAsPrivileged(permission, rolePermission);
     if (!hasPriviledge)
       throw new ForbiddenRequestError({
@@ -135,16 +136,18 @@ export const identityProjectServiceFactory = ({
         message: `Identity with id ${identityId} doesn't exists in project with id ${projectId}`
       });
 
-    const { permission: identityRolePermission } = await permissionService.getProjectPermission(
+    for (const { role: requestedRoleChange } of roles) {
-      ActorType.IDENTITY,
+      const { permission: rolePermission } = await permissionService.getProjectPermissionByRole(
-      projectIdentity.identityId,
+        requestedRoleChange,
-      projectIdentity.projectId,
+        projectId
-      actorAuthMethod,
+      );
-      actorOrgId
+
-    );
+      const hasRequiredPriviledges = isAtLeastAsPrivileged(permission, rolePermission);
-    const hasRequiredPriviledges = isAtLeastAsPrivileged(permission, identityRolePermission);
+
-    if (!hasRequiredPriviledges)
+      if (!hasRequiredPriviledges) {
-      throw new ForbiddenRequestError({ message: "Failed to delete more privileged identity" });
+        throw new ForbiddenRequestError({ message: "Failed to change to a more privileged role" });
+      }
+    }
 
     // validate custom roles input
     const customInputRoles = roles.filter(