From 757942aefcc944e709870791813dc73583ab0676 Mon Sep 17 00:00:00 2001
From: = <akhilmhdh@gmail.com>
Date: Fri, 31 Jan 2025 15:16:27 +0530
Subject: [PATCH] feat: resolved nits

---
 backend/src/ee/services/group/group-service.ts              | 2 +-
 backend/src/lib/casl/boundary.ts                            | 2 +-
 .../services/identity-project/identity-project-service.ts   | 4 ++--
 backend/src/services/identity-ua/identity-ua-service.ts     | 6 +++---
 backend/src/services/identity/identity-service.ts           | 4 ++--
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/backend/src/ee/services/group/group-service.ts b/backend/src/ee/services/group/group-service.ts
index 7f1bca5d8..27e847896 100644
--- a/backend/src/ee/services/group/group-service.ts
+++ b/backend/src/ee/services/group/group-service.ts
@@ -165,7 +165,7 @@ export const groupServiceFactory = ({
       if (!permissionBoundary.isValid)
         throw new ForbiddenRequestError({
           name: "PermissionBoundaryError",
-          message: "Failed to create a more privileged group",
+          message: "Failed to update a more privileged group",
           details: { missingPermissions: permissionBoundary.missingPermissions }
         });
       if (isCustomRole) customRole = customOrgRole;
diff --git a/backend/src/lib/casl/boundary.ts b/backend/src/lib/casl/boundary.ts
index dee006f25..15592a7bd 100644
--- a/backend/src/lib/casl/boundary.ts
+++ b/backend/src/lib/casl/boundary.ts
@@ -29,7 +29,7 @@ const isOperatorsASubset = (parentSet: TPermissionConditionShape, subset: TPermi
   // we compute each operator against each other in left hand side and right hand side
   if (subset[PermissionConditionOperators.$EQ] || subset[PermissionConditionOperators.$NEQ]) {
     const subsetOperatorValue = subset[PermissionConditionOperators.$EQ] || subset[PermissionConditionOperators.$NEQ];
-    const isInverted = Boolean(subset[PermissionConditionOperators.$NEQ]);
+    const isInverted = !subset[PermissionConditionOperators.$EQ];
     if (
       parentSet[PermissionConditionOperators.$EQ] &&
       invertTheOperation(isInverted, parentSet[PermissionConditionOperators.$EQ] !== subsetOperatorValue)
diff --git a/backend/src/services/identity-project/identity-project-service.ts b/backend/src/services/identity-project/identity-project-service.ts
index 0b71165e2..e16ffb3d4 100644
--- a/backend/src/services/identity-project/identity-project-service.ts
+++ b/backend/src/services/identity-project/identity-project-service.ts
@@ -95,7 +95,7 @@ export const identityProjectServiceFactory = ({
       if (!permissionBoundary.isValid)
         throw new ForbiddenRequestError({
           name: "PermissionBoundaryError",
-          message: "Failed to change to a more privileged role",
+          message: "Failed to assign to a more privileged role",
           details: { missingPermissions: permissionBoundary.missingPermissions }
         });
     }
@@ -287,7 +287,7 @@ export const identityProjectServiceFactory = ({
     if (!permissionBoundary.isValid)
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
-        message: "Failed to delete more privileged identity",
+        message: "Failed to remove more privileged identity",
         details: { missingPermissions: permissionBoundary.missingPermissions }
       });
 
diff --git a/backend/src/services/identity-ua/identity-ua-service.ts b/backend/src/services/identity-ua/identity-ua-service.ts
index 650f0511b..078b50c08 100644
--- a/backend/src/services/identity-ua/identity-ua-service.ts
+++ b/backend/src/services/identity-ua/identity-ua-service.ts
@@ -421,7 +421,7 @@ export const identityUaServiceFactory = ({
     if (!permissionBoundary.isValid)
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
-        message: "Failed to add identity to project with more privileged role",
+        message: "Failed to create client secret for a more privileged identity.",
         details: { missingPermissions: permissionBoundary.missingPermissions }
       });
 
@@ -484,7 +484,7 @@ export const identityUaServiceFactory = ({
     if (!permissionBoundary.isValid)
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
-        message: "Failed to get identity with more privileged role",
+        message: "Failed to get identity client secret with more privileged role",
         details: { missingPermissions: permissionBoundary.missingPermissions }
       });
 
@@ -536,7 +536,7 @@ export const identityUaServiceFactory = ({
     if (!permissionBoundary.isValid)
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
-        message: "Failed to read identity client secret of project with more privileged role",
+        message: "Failed to read identity client secret of identity with more privileged role",
         details: { missingPermissions: permissionBoundary.missingPermissions }
       });
 
diff --git a/backend/src/services/identity/identity-service.ts b/backend/src/services/identity/identity-service.ts
index 68ec75287..8ada2a5d1 100644
--- a/backend/src/services/identity/identity-service.ts
+++ b/backend/src/services/identity/identity-service.ts
@@ -137,7 +137,7 @@ export const identityServiceFactory = ({
     if (!permissionBoundary.isValid)
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
-        message: "Failed to delete a more privileged identity",
+        message: "Failed to update a more privileged identity",
         details: { missingPermissions: permissionBoundary.missingPermissions }
       });
 
@@ -232,7 +232,7 @@ export const identityServiceFactory = ({
     if (!permissionBoundary.isValid)
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
-        message: "Failed to delete more privileged user",
+        message: "Failed to delete more privileged identity",
         details: { missingPermissions: permissionBoundary.missingPermissions }
       });