From 7581300a67d5ca79f013b4622dd35b1c4ee86e8f Mon Sep 17 00:00:00 2001 From: carlosmonastyrski Date: Thu, 19 Jun 2025 13:38:20 -0300 Subject: [PATCH] feat(secret-sync): minor fix on heroku sync --- backend/src/services/secret-sync/heroku/heroku-sync-fns.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/src/services/secret-sync/heroku/heroku-sync-fns.ts b/backend/src/services/secret-sync/heroku/heroku-sync-fns.ts index 402b0bb2c..d2f0817db 100644 --- a/backend/src/services/secret-sync/heroku/heroku-sync-fns.ts +++ b/backend/src/services/secret-sync/heroku/heroku-sync-fns.ts @@ -79,8 +79,6 @@ export const HerokuSyncFns = { const authToken = await getValidAuthToken(connection, appConnectionDAL, kmsService); try { - const currentConfigVars = await getHerokuConfigVars({ authToken, app }); - const updatedConfigVars: THerokuConfigVars = {}; for (const [key, { value }] of Object.entries(secretMap)) { @@ -88,6 +86,8 @@ export const HerokuSyncFns = { } if (!secretSync.syncOptions.disableSecretDeletion) { + const currentConfigVars = await getHerokuConfigVars({ authToken, app }); + for (const key of Object.keys(currentConfigVars)) { if (matchesSchema(key, environment?.slug || "", secretSync.syncOptions.keySchema) && !(key in secretMap)) { updatedConfigVars[key] = null;