From 7826324435c1b034abe7b42075536a1d8949de07 Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Fri, 14 Feb 2025 08:54:37 -0800 Subject: [PATCH] fix: use isPending over isLoading --- frontend/src/components/secret-syncs/SecretSyncSelect.tsx | 4 ++-- .../AppConnectionsPage/components/AppConnectionList.tsx | 4 ++-- .../AppConnectionsPage/components/AppConnectionsTable.tsx | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/frontend/src/components/secret-syncs/SecretSyncSelect.tsx b/frontend/src/components/secret-syncs/SecretSyncSelect.tsx index 6e3030a01..cbcba4513 100644 --- a/frontend/src/components/secret-syncs/SecretSyncSelect.tsx +++ b/frontend/src/components/secret-syncs/SecretSyncSelect.tsx @@ -10,9 +10,9 @@ type Props = { }; export const SecretSyncSelect = ({ onSelect }: Props) => { - const { isLoading, data: secretSyncOptions } = useSecretSyncOptions(); + const { isPending, data: secretSyncOptions } = useSecretSyncOptions(); - if (isLoading) { + if (isPending) { return (
diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionList.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionList.tsx index 5db13f714..e6abba757 100644 --- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionList.tsx +++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionList.tsx @@ -11,9 +11,9 @@ type Props = { }; export const AppConnectionsSelect = ({ onSelect }: Props) => { - const { isLoading, data: appConnectionOptions } = useAppConnectionOptions(); + const { isPending, data: appConnectionOptions } = useAppConnectionOptions(); - if (isLoading) { + if (isPending) { return (
diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsx index ee71669ba..379ce877c 100644 --- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsx +++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsx @@ -51,7 +51,7 @@ type AppConnectionFilters = { }; export const AppConnectionsTable = () => { - const { isLoading, data: appConnections = [] } = useListAppConnections(); + const { isPending, data: appConnections = [] } = useListAppConnections(); const { popUp, handlePopUpOpen, handlePopUpToggle } = usePopUp([ "deleteConnection", @@ -262,7 +262,7 @@ export const AppConnectionsTable = () => { - {isLoading && ( + {isPending && ( )} {filteredAppConnections.slice(offset, perPage * page).map((connection) => ( @@ -285,7 +285,7 @@ export const AppConnectionsTable = () => { onChangePerPage={setPerPage} /> )} - {!isLoading && !filteredAppConnections?.length && ( + {!isPending && !filteredAppConnections?.length && (