Fix greptile reviews

backend/src/server/routes/v1/app-connection-routers/cloudflare-connection-router.ts

@@ -53,7 +53,7 @@ export const registerCloudflareConnectionRouter = async (server: FastifyZodProvi
 
   server.route({
     method: "GET",
-    url: `/:connectionId/cloudflare-workers-projects`,
+    url: `/:connectionId/cloudflare-workers-scripts`,
     config: {
       rateLimit: readLimit
     },
@@ -73,7 +73,7 @@ export const registerCloudflareConnectionRouter = async (server: FastifyZodProvi
     handler: async (req) => {
       const { connectionId } = req.params;
 
-      const projects = await server.services.appConnection.cloudflare.listWorkersProjects(connectionId, req.permission);
+      const projects = await server.services.appConnection.cloudflare.listWorkersScripts(connectionId, req.permission);
 
       return projects;
     }

backend/src/services/app-connection/cloudflare/cloudflare-connection-fns.ts

@@ -10,7 +10,7 @@ import {
   TCloudflareConnection,
   TCloudflareConnectionConfig,
   TCloudflarePagesProject,
-  TCloudflareWorkersProject
+  TCloudflareWorkersScript
 } from "./cloudflare-connection-types";
 
 export const getCloudflareConnectionListItem = () => {
@@ -44,9 +44,9 @@ export const listCloudflarePagesProjects = async (
   }));
 };
 
-export const listCloudflareWorkersProjects = async (
+export const listCloudflareWorkersScripts = async (
   appConnection: TCloudflareConnection
-): Promise<TCloudflareWorkersProject[]> => {
+): Promise<TCloudflareWorkersScript[]> => {
   const {
     credentials: { apiToken, accountId }
   } = appConnection;

backend/src/services/app-connection/cloudflare/cloudflare-connection-service.ts

@@ -2,7 +2,7 @@ import { logger } from "@app/lib/logger";
 import { OrgServiceActor } from "@app/lib/types";
 
 import { AppConnection } from "../app-connection-enums";
-import { listCloudflarePagesProjects, listCloudflareWorkersProjects } from "./cloudflare-connection-fns";
+import { listCloudflarePagesProjects, listCloudflareWorkersScripts } from "./cloudflare-connection-fns";
 import { TCloudflareConnection } from "./cloudflare-connection-types";
 
 type TGetAppConnectionFunc = (
@@ -19,25 +19,31 @@ export const cloudflareConnectionService = (getAppConnection: TGetAppConnectionF
 
       return projects;
     } catch (error) {
-      logger.error(error, "Failed to list Cloudflare Pages projects for Cloudflare connection");
+      logger.error(
+        error,
+        `Failed to list Cloudflare Pages projects for Cloudflare connection [connectionId=${connectionId}]`
+      );
       return [];
     }
   };
 
-  const listWorkersProjects = async (connectionId: string, actor: OrgServiceActor) => {
+  const listWorkersScripts = async (connectionId: string, actor: OrgServiceActor) => {
     const appConnection = await getAppConnection(AppConnection.Cloudflare, connectionId, actor);
     try {
-      const projects = await listCloudflareWorkersProjects(appConnection);
+      const projects = await listCloudflareWorkersScripts(appConnection);
 
       return projects;
     } catch (error) {
-      logger.error(error, "Failed to list Cloudflare Workers projects for Cloudflare connection");
+      logger.error(
+        error,
+        `Failed to list Cloudflare Workers scripts for Cloudflare connection [connectionId=${connectionId}]`
+      );
       return [];
     }
   };
 
   return {
     listPagesProjects,
-    listWorkersProjects
+    listWorkersScripts
   };
 };

backend/src/services/app-connection/cloudflare/cloudflare-connection-types.ts

@@ -29,6 +29,6 @@ export type TCloudflarePagesProject = {
   name: string;
 };
 
-export type TCloudflareWorkersProject = {
+export type TCloudflareWorkersScript = {
   id: string;
 };

backend/src/services/secret-sync/cloudflare-workers/cloudflare-workers-schemas.ts

@@ -1,3 +1,4 @@
+import RE2 from "re2";
 import { z } from "zod";
 
 import { SecretSyncs } from "@app/lib/api-docs";
@@ -14,6 +15,8 @@ const CloudflareWorkersSyncDestinationConfigSchema = z.object({
   scriptId: z
     .string()
     .min(1, "Script ID is required")
+    .max(64)
+    .regex(new RE2(/^[a-z0-9]([a-z0-9-]*[a-z0-9])?$/), "Invalid script ID format")
     .describe(SecretSyncs.DESTINATION_CONFIG.CLOUDFLARE_WORKERS.scriptId)
 });