From 7a4a877e391dfbd420586405ef9a351667ae1715 Mon Sep 17 00:00:00 2001 From: carlosmonastyrski Date: Fri, 25 Apr 2025 12:38:41 -0300 Subject: [PATCH] feat(aws-iam-rotation): remove credentials validation due to excesive await time --- .../aws-iam-user-secret-rotation-fns.ts | 24 +------------------ 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/backend/src/ee/services/secret-rotation-v2/aws-iam-user-secret/aws-iam-user-secret-rotation-fns.ts b/backend/src/ee/services/secret-rotation-v2/aws-iam-user-secret/aws-iam-user-secret-rotation-fns.ts index 3e37b962b..c08eb162b 100644 --- a/backend/src/ee/services/secret-rotation-v2/aws-iam-user-secret/aws-iam-user-secret-rotation-fns.ts +++ b/backend/src/ee/services/secret-rotation-v2/aws-iam-user-secret/aws-iam-user-secret-rotation-fns.ts @@ -11,17 +11,7 @@ import { TRotationFactoryRevokeCredentials, TRotationFactoryRotateCredentials } from "@app/ee/services/secret-rotation-v2/secret-rotation-v2-types"; -import { AppConnection } from "@app/services/app-connection/app-connection-enums"; -import { - AwsConnectionMethod, - getAwsConnectionConfig, - validateAwsConnectionCredentials -} from "@app/services/app-connection/aws"; - -const sleep = async () => - new Promise((resolve) => { - setTimeout(resolve, 10000); - }); +import { getAwsConnectionConfig } from "@app/services/app-connection/aws"; const getCreateDate = (key: AWS.IAM.AccessKeyMetadata): number => { return key.CreateDate ? new Date(key.CreateDate).getTime() : 0; @@ -63,18 +53,6 @@ export const awsIamUserSecretRotationFactory: TRotationFactory< const { AccessKey } = await iam.createAccessKey({ UserName: userName }).promise(); - await sleep(); - - await validateAwsConnectionCredentials({ - app: AppConnection.AWS, - orgId: connection.orgId, - method: AwsConnectionMethod.AccessKey, - credentials: { - accessKeyId: AccessKey.AccessKeyId, - secretAccessKey: AccessKey.SecretAccessKey - } - }); - return { accessKeyId: AccessKey.AccessKeyId, secretAccessKey: AccessKey.SecretAccessKey