From 7b5c86f4ef1854923f989c6f20ae6261ddb7f3ae Mon Sep 17 00:00:00 2001
From: Scott Wilson <scottraywilson@gmail.com>
Date: Tue, 17 Jun 2025 17:34:00 -0700
Subject: [PATCH] revert previous commit

---
 .../services/secret-sync/secret-sync-service.ts  | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/backend/src/services/secret-sync/secret-sync-service.ts b/backend/src/services/secret-sync/secret-sync-service.ts
index 54393a3bb..3fdb7fea6 100644
--- a/backend/src/services/secret-sync/secret-sync-service.ts
+++ b/backend/src/services/secret-sync/secret-sync-service.ts
@@ -2,8 +2,10 @@ import { ForbiddenError, subject } from "@casl/ability";
 
 import { ActionProjectType } from "@app/db/schemas";
 import { TLicenseServiceFactory } from "@app/ee/services/license/license-service";
+import { throwIfMissingSecretReadValueOrDescribePermission } from "@app/ee/services/permission/permission-fns";
 import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
 import {
+  ProjectPermissionSecretActions,
   ProjectPermissionSecretSyncActions,
   ProjectPermissionSub
 } from "@app/ee/services/permission/project-permission";
@@ -246,6 +248,15 @@ export const secretSyncServiceFactory = ({
       subject(ProjectPermissionSub.SecretSyncs, { environment, secretPath })
     );
 
+    throwIfMissingSecretReadValueOrDescribePermission(
+      projectPermission,
+      ProjectPermissionSecretActions.DescribeSecret,
+      {
+        environment,
+        secretPath
+      }
+    );
+
     const folder = await folderDAL.findBySecretPath(projectId, environment, secretPath);
 
     if (!folder)
@@ -364,6 +375,11 @@ export const secretSyncServiceFactory = ({
       if (!updatedEnvironment || !updatedSecretPath)
         throw new BadRequestError({ message: "Must specify both source environment and secret path" });
 
+      throwIfMissingSecretReadValueOrDescribePermission(permission, ProjectPermissionSecretActions.DescribeSecret, {
+        environment: updatedEnvironment,
+        secretPath: updatedSecretPath
+      });
+
       const newFolder = await folderDAL.findBySecretPath(secretSync.projectId, updatedEnvironment, updatedSecretPath);
 
       if (!newFolder)