improvement: address feedback

This commit is contained in:
Scott Wilson
2025-05-14 08:58:29 -07:00
parent 7ed96164e5
commit 7e05bc86a9
2 changed files with 33 additions and 41 deletions
@@ -47,29 +47,25 @@ const Content = ({ role, onClose }: ContentProps) => {
const navigate = useNavigate(); const navigate = useNavigate();
const handleDuplicateRole = async (form: FormData) => { const handleDuplicateRole = async (form: FormData) => {
try { const newRole = await createRole.mutateAsync({
const newRole = await createRole.mutateAsync({ orgId: role.orgId,
orgId: role.orgId, permissions: role.permissions,
permissions: role.permissions, ...form
...form });
});
createNotification({ createNotification({
type: "success", type: "success",
text: "Role duplicated successfully" text: "Role duplicated successfully"
}); });
navigate({ navigate({
to: "/organization/roles/$roleId", to: "/organization/roles/$roleId",
params: { params: {
roleId: newRole.id roleId: newRole.id
} }
}); });
onClose(); onClose();
} catch {
// query client creates notification
}
}; };
return ( return (
@@ -49,30 +49,26 @@ const Content = ({ role, onClose }: ContentProps) => {
const navigate = useNavigate(); const navigate = useNavigate();
const handleDuplicateRole = async (form: FormData) => { const handleDuplicateRole = async (form: FormData) => {
try { const newRole = await createRole.mutateAsync({
const newRole = await createRole.mutateAsync({ projectId: currentWorkspace.id,
projectId: currentWorkspace.id, permissions: role.permissions,
permissions: role.permissions, ...form
...form });
});
createNotification({ createNotification({
type: "success", type: "success",
text: "Role duplicated successfully" text: "Role duplicated successfully"
}); });
navigate({ navigate({
to: `/${currentWorkspace.type}/$projectId/roles/$roleSlug` as const, to: `/${currentWorkspace.type}/$projectId/roles/$roleSlug` as const,
params: { params: {
roleSlug: newRole.slug, roleSlug: newRole.slug,
projectId: currentWorkspace.id projectId: currentWorkspace.id
} }
}); });
onClose(); onClose();
} catch {
// query client creates notification
}
}; };
return ( return (