From d4609829fa7155598d7a33ffe161ff3e91f5c255 Mon Sep 17 00:00:00 2001 From: x032205 Date: Tue, 9 Dec 2025 11:56:41 -0500 Subject: [PATCH 1/7] improve some wording & hide max request TTL for simplicity --- .../PolicyTab/components/PoliciesTable.tsx | 12 +++++------- .../components/PolicySteps/PolicyDetailsStep.tsx | 4 +++- .../components/PolicySteps/PolicyReviewStep.tsx | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PoliciesTable.tsx b/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PoliciesTable.tsx index bcfbf6220..4810dbe96 100644 --- a/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PoliciesTable.tsx +++ b/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PoliciesTable.tsx @@ -98,9 +98,7 @@ export const PoliciesTable = ({ handlePopUpOpen }: Props) => { Policy Name - Max Approval Request TTL - Min Access Duration - Max Access Duration + Access Duration (min - max) Conditions @@ -117,7 +115,6 @@ export const PoliciesTable = ({ handlePopUpOpen }: Props) => { {!isPoliciesLoading && policies.map((policy) => { const isExpanded = expandedRows.has(policy.id); - const maxTtl = policy.maxRequestTtl ? policy.maxRequestTtl : "No limit"; const conditionsCount = policy.conditions.conditions.length; return ( @@ -144,9 +141,10 @@ export const PoliciesTable = ({ handlePopUpOpen }: Props) => { {policy.name} - {maxTtl} - {policy.constraints.constraints.accessDuration.min} - {policy.constraints.constraints.accessDuration.max} + + {policy.constraints.constraints.accessDuration.min} -{" "} + {policy.constraints.constraints.accessDuration.max} + {conditionsCount} condition{conditionsCount !== 1 ? "s" : ""} diff --git a/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyDetailsStep.tsx b/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyDetailsStep.tsx index ef6800c71..228d474ad 100644 --- a/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyDetailsStep.tsx +++ b/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyDetailsStep.tsx @@ -24,7 +24,8 @@ export const PolicyDetailsStep = () => { )} /> - ( @@ -38,6 +39,7 @@ export const PolicyDetailsStep = () => { )} /> + */}

diff --git a/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyReviewStep.tsx b/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyReviewStep.tsx index 7dacb73c9..7abb78867 100644 --- a/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyReviewStep.tsx +++ b/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyReviewStep.tsx @@ -187,8 +187,8 @@ export const PolicyReviewStep = () => { {/* Summary Notice */}

- Please review all the details above. Click "Create" to save this policy or - "Back" to make changes. + Please review all the details above. Submit to save this policy or go back to make + changes.

From 36768f05b28e13ef788d604283039103aa8f0a9a Mon Sep 17 00:00:00 2001 From: x032205 Date: Tue, 9 Dec 2025 12:00:45 -0500 Subject: [PATCH 2/7] fix empty policy step name issue --- .../components/PolicyTab/components/PolicySchema.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySchema.tsx b/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySchema.tsx index ff76ddd1b..e371c0663 100644 --- a/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySchema.tsx +++ b/frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySchema.tsx @@ -40,7 +40,12 @@ export const PolicyFormSchema = z.object({ }), steps: z .object({ - name: z.string().max(128).nullable().optional(), + name: z + .string() + .max(128) + .nullable() + .optional() + .transform((name) => name || null), requiredApprovals: z.number().min(1).max(100), notifyApprovers: z.boolean().optional(), approvers: z From e40cbe7e58648b16c17d45bc7f00de1eb21233f7 Mon Sep 17 00:00:00 2001 From: x032205 Date: Tue, 9 Dec 2025 13:31:41 -0500 Subject: [PATCH 3/7] general improvements --- .../ApprovalRequestDetailPage.tsx | 4 +- .../components/ApprovalStepsSection.tsx | 2 +- .../components/RequestActionsSection.tsx | 2 +- .../ApprovalRequestTab/ApprovalRequestTab.tsx | 14 +-- .../components/PolicyTab/PolicyTab.tsx | 11 +- .../PolicyTab/components/PoliciesTable.tsx | 7 +- .../PolicyTab/components/PolicyModal.tsx | 21 ++-- .../PolicyTab/components/PolicySchema.tsx | 8 +- .../PolicySteps/PolicyApprovalSteps.tsx | 2 +- .../PolicySteps/PolicyConstraintsStep.tsx | 102 --------------- .../PolicySteps/PolicyDetailsStep.tsx | 117 ++++++++---------- .../PolicySteps/PolicyReviewStep.tsx | 60 ++------- .../RequestGrantTab/RequestGrantTab.tsx | 7 +- 13 files changed, 110 insertions(+), 247 deletions(-) delete mode 100644 frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyConstraintsStep.tsx diff --git a/frontend/src/pages/pam/ApprovalRequestDetailPage/ApprovalRequestDetailPage.tsx b/frontend/src/pages/pam/ApprovalRequestDetailPage/ApprovalRequestDetailPage.tsx index 65ba38e78..31a846d4c 100644 --- a/frontend/src/pages/pam/ApprovalRequestDetailPage/ApprovalRequestDetailPage.tsx +++ b/frontend/src/pages/pam/ApprovalRequestDetailPage/ApprovalRequestDetailPage.tsx @@ -119,8 +119,8 @@ const PageContent = () => { )}
-
-
+
+
diff --git a/frontend/src/pages/pam/ApprovalRequestDetailPage/components/ApprovalStepsSection.tsx b/frontend/src/pages/pam/ApprovalRequestDetailPage/components/ApprovalStepsSection.tsx index 17bfae8a0..74ff4b4e7 100644 --- a/frontend/src/pages/pam/ApprovalRequestDetailPage/components/ApprovalStepsSection.tsx +++ b/frontend/src/pages/pam/ApprovalRequestDetailPage/components/ApprovalStepsSection.tsx @@ -75,7 +75,7 @@ export const ApprovalStepsSection = ({ request }: Props) => { return (
-

Approval Workflow

+

Approval Sequence

{request.steps.map((step, index) => ( diff --git a/frontend/src/pages/pam/ApprovalRequestDetailPage/components/RequestActionsSection.tsx b/frontend/src/pages/pam/ApprovalRequestDetailPage/components/RequestActionsSection.tsx index 1fb216ebd..20dc6b1e1 100644 --- a/frontend/src/pages/pam/ApprovalRequestDetailPage/components/RequestActionsSection.tsx +++ b/frontend/src/pages/pam/ApprovalRequestDetailPage/components/RequestActionsSection.tsx @@ -127,7 +127,7 @@ export const RequestActionsSection = ({ request }: Props) => { Review - +