Review fixes:

- Review envName from endpoint params and derive it
- Use variables in logic blocks
- New function on frontend + memoization
This commit is contained in:
x032205
2025-05-23 12:05:38 -04:00
parent e81991c545
commit 804f8be07d
6 changed files with 112 additions and 149 deletions
@@ -155,7 +155,6 @@ export const registerAccessApprovalRequestRouter = async (server: FastifyZodProv
}),
body: z.object({
status: z.enum([ApprovalStatus.APPROVED, ApprovalStatus.REJECTED]),
envName: z.string().optional(), // For logging
bypassReason: z.string().min(10).max(1000).optional()
}),
response: {
@@ -173,7 +172,6 @@ export const registerAccessApprovalRequestRouter = async (server: FastifyZodProv
actorAuthMethod: req.permission.authMethod,
requestId: req.params.requestId,
status: req.body.status,
envName: req.body.envName,
bypassReason: req.body.bypassReason
});