Review fixes:

- Review envName from endpoint params and derive it
- Use variables in logic blocks
- New function on frontend + memoization
This commit is contained in:
x032205
2025-05-23 12:05:38 -04:00
parent e81991c545
commit 804f8be07d
6 changed files with 112 additions and 149 deletions
@@ -129,30 +129,27 @@ export const useReviewAccessRequest = () => {
requestId: string;
status: "approved" | "rejected";
projectSlug: string;
envName?: string;
envSlug?: string;
requestedBy?: string;
bypassReason?: string;
}
>({
mutationFn: async ({ requestId, status, envName, bypassReason }) => {
mutationFn: async ({ requestId, status, bypassReason }) => {
const { data } = await apiRequest.post(
`/api/v1/access-approvals/requests/${requestId}/review`,
{
status,
envName,
bypassReason
}
);
return data;
},
onSuccess: (_, { projectSlug, envSlug, requestedBy, envName, bypassReason }) => {
onSuccess: (_, { projectSlug, envSlug, requestedBy, bypassReason }) => {
queryClient.invalidateQueries({
queryKey: accessApprovalKeys.getAccessApprovalRequests(
projectSlug,
envSlug,
requestedBy,
envName,
bypassReason
)
});
@@ -23,13 +23,8 @@ export const accessApprovalKeys = {
projectSlug: string,
envSlug?: string,
requestedBy?: string,
envName?: string,
bypassReason?: string
) =>
[
{ projectSlug, envSlug, requestedBy, envName, bypassReason },
"access-approvals-requests"
] as const,
) => [{ projectSlug, envSlug, requestedBy, bypassReason }, "access-approvals-requests"] as const,
getAccessApprovalRequestCount: (projectSlug: string) =>
[{ projectSlug }, "access-approval-request-count"] as const
};