From 81b45b24ec3c72767fa2a6852832fbc63efea71e Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Mon, 28 Jul 2025 15:16:10 -0700 Subject: [PATCH] improvement: address greptile feedback --- .../secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.ts | 2 +- .../secret-scanning-v2/gitlab/gitlab-secret-scanning-service.ts | 2 +- .../GitLabDataSourceConfigFields.tsx | 2 -- frontend/src/helpers/secretScanningV2.ts | 2 +- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.ts b/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.ts index b83d82d51..6ea294c1f 100644 --- a/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.ts +++ b/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.ts @@ -128,7 +128,7 @@ export const GitLabSecretScanningFactory = ({ appConnectionDAL, kmsService }: TS }); } catch (error) { if (error instanceof GitbeakerRequestError) { - throw new BadRequestError({ message: error.message }); + throw new BadRequestError({ message: `${error.message}: ${error.cause?.description ?? "Unknown Error"}` }); } throw error; diff --git a/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-service.ts b/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-service.ts index 98d20f642..bc669a2f5 100644 --- a/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-service.ts +++ b/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-service.ts @@ -22,7 +22,7 @@ export const gitlabSecretScanningService = ( logger.warn( `secretScanningV2PushEvent: GitLab - Insufficient data [changes=${ payload.total_commits_count ?? 0 - }] [projectName=${payload.project.path_with_namespace}] [projectId=${payload.project.id}]` + }] [projectName=${payload.project?.path_with_namespace ?? "unknown"}] [projectId=${payload.project?.id ?? "unknown"}]` ); return; } diff --git a/frontend/src/components/secret-scanning/forms/SecretScanningDataSourceConfigFields/GitLabDataSourceConfigFields.tsx b/frontend/src/components/secret-scanning/forms/SecretScanningDataSourceConfigFields/GitLabDataSourceConfigFields.tsx index 825ee550d..984e99fd2 100644 --- a/frontend/src/components/secret-scanning/forms/SecretScanningDataSourceConfigFields/GitLabDataSourceConfigFields.tsx +++ b/frontend/src/components/secret-scanning/forms/SecretScanningDataSourceConfigFields/GitLabDataSourceConfigFields.tsx @@ -29,8 +29,6 @@ export const GitLabDataSourceConfigFields = () => { } >(); - console.log(formState); - const connectionId = useWatch({ control, name: "connection.id" }); const isUpdate = Boolean(watch("id")); diff --git a/frontend/src/helpers/secretScanningV2.ts b/frontend/src/helpers/secretScanningV2.ts index 588c61c1b..4e88b8482 100644 --- a/frontend/src/helpers/secretScanningV2.ts +++ b/frontend/src/helpers/secretScanningV2.ts @@ -70,7 +70,7 @@ export const RESOURCE_DESCRIPTION_HELPER: Record< pluralNoun: "projects", singularNoun: "project", pluralTitle: "Projects", - singularTitle: "project" + singularTitle: "Project" } };