From 83465dff2df9f10d8cd3cf901c670eced68be61e Mon Sep 17 00:00:00 2001 From: Vladyslav Matsiiako Date: Sun, 13 Aug 2023 18:26:41 -0700 Subject: [PATCH] added a check for signup events --- backend/src/controllers/v3/secretsController.ts | 6 ++++-- backend/src/helpers/secrets.ts | 5 +++-- backend/src/interfaces/services/SecretService/index.ts | 1 + frontend/src/helpers/project.ts | 3 ++- frontend/src/hooks/api/secrets/types.ts | 1 + 5 files changed, 11 insertions(+), 5 deletions(-) diff --git a/backend/src/controllers/v3/secretsController.ts b/backend/src/controllers/v3/secretsController.ts index 4b6c1adab..bbfc74a52 100644 --- a/backend/src/controllers/v3/secretsController.ts +++ b/backend/src/controllers/v3/secretsController.ts @@ -362,7 +362,8 @@ export const createSecret = async (req: Request, res: Response) => { secretCommentCiphertext, secretCommentIV, secretCommentTag, - secretPath = "/" + secretPath = "/", + source } = req.body; const secret = await SecretService.createSecret({ @@ -380,7 +381,8 @@ export const createSecret = async (req: Request, res: Response) => { secretPath, secretCommentCiphertext, secretCommentIV, - secretCommentTag + secretCommentTag, + source }); await EventService.handleEvent({ diff --git a/backend/src/helpers/secrets.ts b/backend/src/helpers/secrets.ts index 880e7cee3..a37da47bb 100644 --- a/backend/src/helpers/secrets.ts +++ b/backend/src/helpers/secrets.ts @@ -326,7 +326,8 @@ export const createSecretHelper = async ({ secretCommentCiphertext, secretCommentIV, secretCommentTag, - secretPath = "/" + secretPath = "/", + source }: CreateSecretParams) => { const secretBlindIndex = await generateSecretBlindIndexHelper({ secretName, @@ -463,7 +464,7 @@ export const createSecretHelper = async ({ const postHogClient = await TelemetryService.getPostHogClient(); - if (postHogClient) { + if (postHogClient && source !== "signup") { postHogClient.capture({ event: "secrets added", distinctId: await TelemetryService.getDistinctId({ diff --git a/backend/src/interfaces/services/SecretService/index.ts b/backend/src/interfaces/services/SecretService/index.ts index 678c67711..3fd19fd7a 100644 --- a/backend/src/interfaces/services/SecretService/index.ts +++ b/backend/src/interfaces/services/SecretService/index.ts @@ -17,6 +17,7 @@ export interface CreateSecretParams { secretCommentIV?: string; secretCommentTag?: string; secretPath: string; + source?: string; } export interface GetSecretsParams { diff --git a/frontend/src/helpers/project.ts b/frontend/src/helpers/project.ts index f0cb8ec4c..938d571de 100644 --- a/frontend/src/helpers/project.ts +++ b/frontend/src/helpers/project.ts @@ -140,7 +140,8 @@ const initProjectHelper = async ({ secretCommentCiphertext: secret.secretCommentCiphertext, secretCommentIV: secret.secretCommentIV, secretCommentTag: secret.secretCommentTag, - secretPath: "/" + secretPath: "/", + source: "signup" }); }); diff --git a/frontend/src/hooks/api/secrets/types.ts b/frontend/src/hooks/api/secrets/types.ts index 964bac6c2..a9ad18f65 100644 --- a/frontend/src/hooks/api/secrets/types.ts +++ b/frontend/src/hooks/api/secrets/types.ts @@ -165,4 +165,5 @@ export type CreateSecretDTO = { secretCommentIV: string; secretCommentTag: string; secretPath: string; + source?: string; } \ No newline at end of file