From 841408042e394dd4694822f27d87050fa252444d Mon Sep 17 00:00:00 2001 From: = Date: Thu, 12 Jun 2025 16:00:45 +0530 Subject: [PATCH] feat: ui resolved sequence grouping error --- .../AccessApprovalRequest/components/ReviewAccessModal.tsx | 2 +- .../ApprovalPolicyList/components/ApprovalPolicyRow.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/components/ReviewAccessModal.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/components/ReviewAccessModal.tsx index 878052d83..e6df8d814 100644 --- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/components/ReviewAccessModal.tsx +++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/components/ReviewAccessModal.tsx @@ -180,7 +180,7 @@ export const ReviewAccessRequestModal = ({ const projectGroupsGroupById = groupBy(groupMemberships, (i) => i.group.id); const approversBySequence = policy?.approvers?.reduce( (acc, curr) => { - if (acc.length > 1 && acc[acc.length - 1].sequence === curr.sequence) { + if (acc.length && acc[acc.length - 1].sequence === curr.sequence) { acc[acc.length - 1][curr.type]?.push(curr); return acc; } diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx index b47174869..9b14af5ba 100644 --- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx +++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx @@ -59,7 +59,7 @@ export const ApprovalPolicyRow = ({ const sortedSteps = policy.approvers?.sort((a, b) => (a?.sequence || 0) - (b?.sequence || 0)); const entityInSameSequence = sortedSteps?.reduce( (acc, curr) => { - if (acc.length > 1 && acc[acc.length - 1].sequence === curr.sequence) { + if (acc.length && acc[acc.length - 1].sequence === curr.sequence) { acc[acc.length - 1][curr.type]?.push(curr); return acc; }