awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-11 18:29:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: greptile review comments

Browse Source
This commit is contained in:
Piyush Gupta
2025-10-16 00:08:28 +05:30
parent 906d0f5613
commit 846403d424
8 changed files with 35 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/hooks/api/appConnections/laravel-forge/queries.tsx
+11 -10
View File
@@ -9,9 +9,9 @@ const laravelForgeConnectionKeys = {
all: [...appConnectionKeys.all, "laravel-forge"] as const,
listOrganizations: (connectionId: string) =>
[...laravelForgeConnectionKeys.all, "organizations", connectionId] as const,
listServers: (connectionId: string, organizationSlug?: string) =>
listServers: (connectionId: string, organizationSlug: string) =>
[...laravelForgeConnectionKeys.all, "servers", connectionId, organizationSlug] as const,
listSites: (connectionId: string, organizationSlug?: string, serverId?: string) =>
listSites: (connectionId: string, organizationSlug: string, serverId: number) =>
[...laravelForgeConnectionKeys.all, "sites", connectionId, organizationSlug, serverId] as const
};
@@ -56,7 +56,7 @@ export const useLaravelForgeConnectionListServers = (
return useQuery({
queryKey: laravelForgeConnectionKeys.listServers(connectionId, organizationSlug),
queryFn: async () => {
const params = organizationSlug ? { organizationSlug } : {};
const params = { organizationSlug };
const { data } = await apiRequest.get<TLaravelForgeServer[]>(
`/api/v1/app-connections/laravel-forge/${connectionId}/servers`,
{ params }
@@ -64,15 +64,15 @@ export const useLaravelForgeConnectionListServers = (
return data;
},
enabled: Boolean(connectionId),
enabled: Boolean(connectionId && organizationSlug),
...options
});
};
export const useLaravelForgeConnectionListSites = (
connectionId: string,
organizationSlug?: string,
serverId?: string,
organizationSlug: string,
serverId: number,
options?: Omit<
UseQueryOptions<
TLaravelForgeSite[],
@@ -86,9 +86,10 @@ export const useLaravelForgeConnectionListSites = (
return useQuery({
queryKey: laravelForgeConnectionKeys.listSites(connectionId, organizationSlug, serverId),
queryFn: async () => {
const params: Record<string, string> = {};
if (organizationSlug) params.organizationSlug = organizationSlug;
if (serverId) params.serverId = serverId;
const params = {
organizationSlug,
serverId
};
const { data } = await apiRequest.get<TLaravelForgeSite[]>(
`/api/v1/app-connections/laravel-forge/${connectionId}/sites`,
@@ -97,7 +98,7 @@ export const useLaravelForgeConnectionListSites = (
return data;
},
enabled: Boolean(connectionId),
enabled: Boolean(connectionId && organizationSlug && serverId),
...options
});
};
frontend/src/hooks/api/secretSyncs/types/laravel-forge-sync.ts
+1 -1
View File
@@ -7,7 +7,7 @@ export type TLaravelForgeSync = TRootSecretSync & {
destinationConfig: {
orgSlug: string;
orgName: string;
serverId: string;
serverId: number;
serverName: string;
siteId: string;
siteName: string;
frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncDestinationCol/LaravelForgeSyncDestinationCol.tsx
-1
View File
@@ -10,6 +10,5 @@ type Props = {
export const LaravelForgeSyncDestinationCol = ({ secretSync }: Props) => {
const { primaryText, secondaryText } = getSecretSyncDestinationColValues(secretSync);
console.log({ secretSync });
return <SecretSyncTableCell primaryText={primaryText} secondaryText={secondaryText} />;
};