From 87df5a2749ca675db6e57ef4454b1895f61ca642 Mon Sep 17 00:00:00 2001
From: Sheen Capadngan <sheensantoscapadngan@gmail.com>
Date: Tue, 11 Jun 2024 21:54:14 +0800
Subject: [PATCH] misc: addressed PR comments

---
 .../src/ee/services/secret-snapshot/snapshot-dal.ts    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/backend/src/ee/services/secret-snapshot/snapshot-dal.ts b/backend/src/ee/services/secret-snapshot/snapshot-dal.ts
index 12897e6b9..e45098132 100644
--- a/backend/src/ee/services/secret-snapshot/snapshot-dal.ts
+++ b/backend/src/ee/services/secret-snapshot/snapshot-dal.ts
@@ -363,6 +363,7 @@ export const snapshotDALFactory = (db: TDbClient) => {
               .join(TableName.Environment, `${TableName.Environment}.id`, `${TableName.SecretFolder}.envId`)
               .join(TableName.Project, `${TableName.Project}.id`, `${TableName.Environment}.projectId`)
               .join("snapshot_cte", "snapshot_cte.id", `${TableName.Snapshot}.id`)
+              .whereNull(`${TableName.SecretFolder}.parentId`)
               .whereRaw(`snapshot_cte.row_num > ${TableName.Project}."pitVersionLimit"`)
               .delete();
           } catch (err) {
@@ -434,12 +435,11 @@ export const snapshotDALFactory = (db: TDbClient) => {
 
       // cleanup orphaned snapshots (those that don't belong to an existing folder and folder version)
       await db(TableName.Snapshot)
-        .whereNotIn("folderId", function () {
-          void this.select("folderId")
+        .whereNotIn("folderId", (qb) => {
+          void qb
+            .select("folderId")
             .from(TableName.SecretFolderVersion)
-            .union(function () {
-              void this.select("id").from(TableName.SecretFolder);
-            });
+            .union((qb1) => void qb1.select("id").from(TableName.SecretFolder));
         })
         .delete();
     } catch (error) {