awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-18 02:56:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: resolved review feedbacks

Browse Source
This commit is contained in:
=
2025-10-10 00:09:47 +05:30
parent 879bc00eeb
commit 8b464c862f
8 changed files with 425 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/additional-privilege/additional-privilege-service.ts
+2 -2
View File
@@ -93,7 +93,7 @@ export const additionalPrivilegeServiceFactory = ({
[scope.key]: scope.value,
name: data.name,
isTemporary: data.isTemporary,
permissions: data.permissions,
permissions: JSON.stringify(packRules(data.permissions as RawRule[])),
temporaryAccessEndTime: new Date(
new Date(data.temporaryAccessStartTime).getTime() + relativeTempAllocatedTimeInMs
),
@@ -148,7 +148,7 @@ export const additionalPrivilegeServiceFactory = ({
const additionalPrivilege = await additionalPrivilegeDAL.updateById(existingPrivilege.id, {
name: updatedData.name,
isTemporary: updatedData.isTemporary,
permissions: updatedData.permissions,
permissions: JSON.stringify(packRules(updatedData.permissions as RawRule[])),
temporaryAccessEndTime: new Date(
new Date(updatedData.temporaryAccessStartTime).getTime() + relativeTempAllocatedTimeInMs
),
backend/src/services/membership-group/membership-group-dal.ts
+3
View File
@@ -58,6 +58,7 @@ export const membershipGroupDALFactory = (db: TDbClient) => {
db.ref("name").withSchema(TableName.Groups).as("groupName"),
db.ref("slug").withSchema(TableName.Groups).as("groupSlug"),
db.ref("slug").withSchema(TableName.Role).as("roleSlug"),
db.ref("name").withSchema(TableName.Role).as("roleName"),
db.ref("id").withSchema(TableName.MembershipRole).as("membershipRoleId"),
db.ref("role").withSchema(TableName.MembershipRole).as("membershipRole"),
db.ref("temporaryMode").withSchema(TableName.MembershipRole).as("membershipRoleTemporaryMode"),
@@ -95,6 +96,7 @@ export const membershipGroupDALFactory = (db: TDbClient) => {
label: "roles" as const,
mapper: ({
roleSlug,
roleName,
membershipRoleId,
membershipRole,
membershipRoleIsTemporary,
@@ -108,6 +110,7 @@ export const membershipGroupDALFactory = (db: TDbClient) => {
id: membershipRoleId,
role: membershipRole,
customRoleSlug: roleSlug,
customRoleName: roleName,
temporaryRange: membershipRoleTemporaryRange,
temporaryMode: membershipRoleTemporaryMode,
temporaryAccessStartTime: membershipRoleTemporaryAccessStartTime,